-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training & Inference code for FAcodec #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great works and high-quality code from @Plachtaa! There are some files need to be added the copyright information. Let @HeCheng0625 double check the readme of FACodec!
@@ -0,0 +1,324 @@ | |||
import copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the copyright information
@@ -0,0 +1,298 @@ | |||
import math |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the copyright information
@@ -0,0 +1,354 @@ | |||
import math |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the copyright information
@@ -0,0 +1,617 @@ | |||
from modules.dac.nn.quantize import ResidualVectorQuantize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the copyright information
@@ -0,0 +1,91 @@ | |||
from . import attentions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the copyright information
Hi @RMSnow thanks a lot for reviewing the code! I apologize for the late reply. I have just added copyright statements to all newly added files and source of code where necessary. Please help me check whether the format is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
egs/codec/FAcodec/train.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No "exp_libritts.json" file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ease of data preparation, dataset is denoted as a single directory, where audio samples are recursively searched and loaded, as no transcriptions are required.
Hi @Plachtaa , could you use black formatting to format the code to pass the code style check? The command is just "black .", thanks! |
Sorry for late reply, I have reformatted all changed & new files with black formatter, please have a format check again and see whether it could pass |
β¨ Description
Training & Inference code for FAcodec, include link to pretrained checkpoint
π§ Related Issues
None
π¨βπ» Changes Proposed
env.sh
codec
directory forbins
,models
,egs
π§βπ€βπ§ Who Can Review?
[@zhizhengwu]
π TODO
β Checklist