Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training & Inference code for FAcodec #229

Merged
merged 7 commits into from
Aug 4, 2024
Merged

Conversation

Plachtaa
Copy link
Contributor

@Plachtaa Plachtaa commented Jul 2, 2024

✨ Description

Training & Inference code for FAcodec, include link to pretrained checkpoint

🚧 Related Issues

None

πŸ‘¨β€πŸ’» Changes Proposed

  • Added new requirements to env.sh
  • Added codec directory for bins, models, egs

πŸ§‘β€πŸ€β€πŸ§‘ Who Can Review?

[@zhizhengwu]

πŸ›  TODO

  • To be added...

βœ… Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@RMSnow RMSnow requested a review from HeCheng0625 July 3, 2024 20:31
RMSnow
RMSnow previously requested changes Jul 3, 2024
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great works and high-quality code from @Plachtaa! There are some files need to be added the copyright information. Let @HeCheng0625 double check the readme of FACodec!

@@ -0,0 +1,324 @@
import copy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright information

@@ -0,0 +1,298 @@
import math
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright information

@@ -0,0 +1,354 @@
import math
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright information

@@ -0,0 +1,617 @@
from modules.dac.nn.quantize import ResidualVectorQuantize
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright information

@@ -0,0 +1,91 @@
from . import attentions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright information

modules/dac/nn/__init__.py Show resolved Hide resolved
modules/dac/nn/layers.py Show resolved Hide resolved
modules/dac/nn/loss.py Show resolved Hide resolved
modules/dac/nn/quantize.py Show resolved Hide resolved
egs/codec/FAcodec/README.md Outdated Show resolved Hide resolved
@Plachtaa
Copy link
Contributor Author

Plachtaa commented Jul 7, 2024

Hi @RMSnow thanks a lot for reviewing the code! I apologize for the late reply. I have just added copyright statements to all newly added files and source of code where necessary. Please help me check whether the format is correct.
Thanks!

Copy link
Collaborator

@jiaqili3 jiaqili3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No "exp_libritts.json" file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ease of data preparation, dataset is denoted as a single directory, where audio samples are recursively searched and loaded, as no transcriptions are required.

@jiaqili3
Copy link
Collaborator

Hi @Plachtaa , could you use black formatting to format the code to pass the code style check? The command is just "black .", thanks!

@Plachtaa
Copy link
Contributor Author

Plachtaa commented Jul 25, 2024

Hi @Plachtaa , could you use black formatting to format the code to pass the code style check? The command is just "black .", thanks!

Sorry for late reply, I have reformatted all changed & new files with black formatter, please have a format check again and see whether it could pass

@jiaqili3 jiaqili3 merged commit 211e1d4 into open-mmlab:main Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants