Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for VALLE resume #144

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Fix bug for VALLE resume #144

merged 5 commits into from
Mar 25, 2024

Conversation

lmxue
Copy link
Collaborator

@lmxue lmxue commented Feb 24, 2024

✨ Description

Fix the bug for VALLE resume. Now it supports resume training and finetuning from a default or a specified directory for both two training stages of VALLE.

The updated code has been tested successfully.

🚧 Related Issues

#129

👨‍💻 Changes Proposed

  • Update the part of resume check in models/tts/base/tts_trainer.py
  • Add arguments related to resume in egs/tts/VALLE/run.sh
  • Update recipe in egs/tts/VALLE/README.md with instructions on training from scratch and existing resources

🧑‍🤝‍🧑 Who Can Review?

@HeCheng0625

🛠 TODO

None

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@lmxue lmxue changed the title Valle resume Fix bug for VALLE resume Feb 24, 2024
Copy link
Collaborator

@HeCheng0625 HeCheng0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@HeCheng0625 HeCheng0625 merged commit 1e4a650 into open-mmlab:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants