Skip to content

fix(workflows): add WorkflowEventConsumer pollInterval 10->1 to the 1.13.4 migration - #31350

Open
yan-3005 wants to merge 1 commit into
mainfrom
fix/workflow-poll-interval-1.13.4-migration
Open

fix(workflows): add WorkflowEventConsumer pollInterval 10->1 to the 1.13.4 migration#31350
yan-3005 wants to merge 1 commit into
mainfrom
fix/workflow-poll-interval-1.13.4-migration

Conversation

@yan-3005

Copy link
Copy Markdown
Contributor

What

Adds the WorkflowEventConsumer pollInterval 10 → 1 update to the 1.13.4 native migration (MySQL + Postgres).

Why

The governance event consumer reads the change_event stream on its subscription pollInterval. Installs seeded before the pollInterval=1 change keep pollInterval=10, so under bulk-event load (bulk custom-property / entity operations that flood change_event) the consumer lags minutes behind and governance approval tasks appear too late (approval / glossary workflows time out).

  • The seed WorkflowEvents.json already ships pollInterval:1 (new installs are fine).
  • 2.0.0 already carries the same UPDATE for the 2.0 upgrade path.
  • This adds the idempotent UPDATE to 1.13.4 so installs upgrading to 1.13.4 — ahead of 2.0 — also get it. We can't wait for 2.0.

Change

bootstrap/sql/migrations/native/1.13.4/{mysql,postgres}/postDataMigrationSQLScript.sql:

UPDATE event_subscription_entity
SET json = JSON_SET(json, '$.pollInterval', 1)         -- jsonb_set(..., '{pollInterval}', '1') on postgres
WHERE name = 'WorkflowEventConsumer'
  AND CAST(JSON_EXTRACT(json, '$.pollInterval') AS UNSIGNED) > 1;

Idempotent (only lowers values still above 1), append-only, both DB engines.

🤖 Generated with Claude Code

….13.4 migration

The governance event consumer (WorkflowEventConsumer) polls the change_event stream
on its subscription pollInterval. Installs seeded before the pollInterval=1 change keep
pollInterval=10, so under bulk-event load (bulk custom-property / entity operations that
flood change_event) the consumer lags minutes behind and governance approval tasks appear
too late.

The seed WorkflowEvents.json already ships pollInterval=1, and 2.0.0 carries the same
UPDATE for the 2.0 upgrade path. This adds the idempotent UPDATE to the 1.13.4 native
migration (mysql + postgres) so installs upgrading to 1.13.4 -- ahead of 2.0 -- also get it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 11, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added backend safe to test Add this label to run secure Github workflows on PRs labels Aug 11, 2026
@gitar-bot

gitar-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds the WorkflowEventConsumer pollInterval update to the 1.13.4 native migration scripts for MySQL and Postgres to prevent governance workflow delays. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 0ec282d9503199e0d2ced2c0f06d7c108296f8d7 in Playwright run 31514888175, attempt 1.

✅ 550 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 1h 3m 33s

⏱️ Max setup 3m 55s · max shard execution 18m 44s · max shard-job elapsed before upload 23m 47s · reporting 3s

🌐 210.79 requests/attempt · 2.83 app boots/UI scenario · 25.27% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 25.27% (convergence target: at most 15%).
  • Browser traffic was 210.79 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1617 boots / 571 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 132 0 0 0 0 0
✅ Shard chromium-02 128 0 0 0 0 0
✅ Shard chromium-03 139 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants