fix(workflows): add WorkflowEventConsumer pollInterval 10->1 to the 1.13.4 migration - #31350
fix(workflows): add WorkflowEventConsumer pollInterval 10->1 to the 1.13.4 migration#31350yan-3005 wants to merge 1 commit into
Conversation
….13.4 migration The governance event consumer (WorkflowEventConsumer) polls the change_event stream on its subscription pollInterval. Installs seeded before the pollInterval=1 change keep pollInterval=10, so under bulk-event load (bulk custom-property / entity operations that flood change_event) the consumer lags minutes behind and governance approval tasks appear too late. The seed WorkflowEvents.json already ships pollInterval=1, and 2.0.0 carries the same UPDATE for the 2.0 upgrade path. This adds the idempotent UPDATE to the 1.13.4 native migration (mysql + postgres) so installs upgrading to 1.13.4 -- ahead of 2.0 -- also get it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ ApprovedAdds the WorkflowEventConsumer pollInterval update to the 1.13.4 native migration scripts for MySQL and Postgres to prevent governance workflow delays. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
✅ Playwright Results — workflow succeededValidated commit ✅ 550 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 1h 3m 33s ⏱️ Max setup 3m 55s · max shard execution 18m 44s · max shard-job elapsed before upload 23m 47s · reporting 3s 🌐 210.79 requests/attempt · 2.83 app boots/UI scenario · 25.27% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
What
Adds the
WorkflowEventConsumerpollInterval10 → 1update to the 1.13.4 native migration (MySQL + Postgres).Why
The governance event consumer reads the
change_eventstream on its subscriptionpollInterval. Installs seeded before thepollInterval=1change keeppollInterval=10, so under bulk-event load (bulk custom-property / entity operations that floodchange_event) the consumer lags minutes behind and governance approval tasks appear too late (approval / glossary workflows time out).WorkflowEvents.jsonalready shipspollInterval:1(new installs are fine).2.0.0already carries the sameUPDATEfor the 2.0 upgrade path.UPDATEto1.13.4so installs upgrading to 1.13.4 — ahead of 2.0 — also get it. We can't wait for 2.0.Change
bootstrap/sql/migrations/native/1.13.4/{mysql,postgres}/postDataMigrationSQLScript.sql:Idempotent (only lowers values still above 1), append-only, both DB engines.
🤖 Generated with Claude Code