Skip to content

Fixes search settings.spec.ts playwright failures - #28989

Merged
aniketkatkar97 merged 4 commits into
1.12.11from
fix/searchSettings.spec.ts
Jun 12, 2026
Merged

Fixes search settings.spec.ts playwright failures#28989
aniketkatkar97 merged 4 commits into
1.12.11from
fix/searchSettings.spec.ts

Conversation

@satender-kumar-collate

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #27946

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

@satender-kumar-collate
satender-kumar-collate requested a review from a team as a code owner June 12, 2026 06:27
@satender-kumar-collate satender-kumar-collate added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jun 12, 2026
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@gitar-bot

gitar-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Resolves Playwright failures in searchSettings.spec.ts by removing obsolete column test cases and unused variables. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions

Copy link
Copy Markdown
Contributor

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

❌ Core Components — ESLint + Prettier

One or more core-component files have linting or formatting issues.


Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

@aniketkatkar97
aniketkatkar97 merged commit f31610d into 1.12.11 Jun 12, 2026
37 of 41 checks passed
@aniketkatkar97
aniketkatkar97 deleted the fix/searchSettings.spec.ts branch June 12, 2026 06:33
@github-actions

Copy link
Copy Markdown
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.18% (57858/87425) 45.96% (30791/66990) 48.74% (9238/18950)

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 1 failure(s), 22 flaky

✅ 3473 passed · ❌ 1 failed · 🟡 22 flaky · ⏭️ 97 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 2 705 0 6 9
🔴 Shard 3 717 1 7 6
🟡 Shard 4 729 0 1 19
🟡 Shard 5 671 0 2 35
🟡 Shard 6 651 0 6 28

Genuine Failures (failed on all attempts)

Flow/NotificationAlerts.spec.ts › Multiple Filters Alert (shard 3)
�[31mTest timeout of 60000ms exceeded.�[39m
🟡 22 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Search Index - customization should work (shard 2, 1 retry)
  • Features/DataQuality/ColumnLevelTests.spec.ts › Column Values Sum To Be Between (shard 2, 1 retry)
  • Features/DataQuality/DataQualityPermissions.spec.ts › Admin can see Data Quality UI controls (add test case, add test suite) (shard 2, 1 retry)
  • Features/DataQuality/IncidentManagerDateFilter.spec.ts › Date filter persists on page reload (shard 2, 1 retry)
  • Features/DataQuality/TableLevelTests.spec.ts › Custom SQL Query (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should move term with children to different glossary (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/Permissions/ServiceEntityPermissions.spec.ts › SearchIndex Service allow common operations permissions (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Flow/Metric.spec.ts › verify metric expression update (shard 3, 1 retry)
  • Flow/ServiceForm.spec.ts › Verify form selects are working properly (shard 3, 1 retry)
  • Pages/CustomThemeConfig.spec.ts › Update Hover and selected Color (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Delete Directory (shard 5, 1 retry)
  • Pages/Entity.spec.ts › Delete Spreadsheet (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for container -> searchIndex (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify LineageSearchSelect in lineage mode (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: container (shard 6, 1 retry)
  • Pages/SearchSettings.spec.ts › Preview config reflects reverted n-gram weight after save (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Storage Service (shard 6, 1 retry)
  • Pages/Tag.spec.ts › Add and Remove Assets and Check Restricted Entity (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants