Update playwright.config.ts by chirag-madlani · Pull Request #28931 · open-metadata/OpenMetadata

chirag-madlani · 2026-06-10T15:45:11Z

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

Test reporting:
- Configured playwright.config.ts to include skipped, failed, and flaky results in reports to reduce noise.
- Enabled showArtifactsLink in the reporter configuration to facilitate easier debugging.

_{This will update automatically on new commits.}

gitar-bot · 2026-06-10T15:48:06Z

      {
        useDetails: true,
        showError: true,
+        includeResults: ['skipped', 'fail', 'flaky'], // skip pass to reduce noice


💡 Quality: Typo in comment: "noice" should be "noise"

In playwright.config.ts:58 the inline comment reads // skip pass to reduce noice. "noice" is a typo for "noise". The config itself is correct: includeResults: ['skipped', 'fail', 'flaky'] uses valid status strings accepted by @estruyf/github-actions-reporter v1.7.0, and showArtifactsLink: true is a supported option. Only the comment needs a quick fix.

Fix spelling of "noise" in the comment.:

includeResults: ['skipped', 'fail', 'flaky'], // skip pass to reduce noise

Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-06-10T15:48:08Z

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Updates the Playwright reporter configuration to include filtered test results and artifact links for improved debugging. A minor typo in a comment should be corrected from "noice" to "noise".

💡 Quality: Typo in comment: "noice" should be "noise"

📄 openmetadata-ui/src/main/resources/ui/playwright.config.ts:58

In playwright.config.ts:58 the inline comment reads // skip pass to reduce noice. "noice" is a typo for "noise". The config itself is correct: includeResults: ['skipped', 'fail', 'flaky'] uses valid status strings accepted by @estruyf/github-actions-reporter v1.7.0, and showArtifactsLink: true is a supported option. Only the comment needs a quick fix.

Fix spelling of "noise" in the comment.

includeResults: ['skipped', 'fail', 'flaky'], // skip pass to reduce noise

🤖 Prompt for agents

Code Review: Updates the Playwright reporter configuration to include filtered test results and artifact links for improved debugging. A minor typo in a comment should be corrected from "noice" to "noise".

1. 💡 Quality: Typo in comment: "noice" should be "noise"
   Files: openmetadata-ui/src/main/resources/ui/playwright.config.ts:58

   In playwright.config.ts:58 the inline comment reads `// skip pass to reduce noice`. "noice" is a typo for "noise". The config itself is correct: `includeResults: ['skipped', 'fail', 'flaky']` uses valid status strings accepted by @estruyf/github-actions-reporter v1.7.0, and `showArtifactsLink: true` is a supported option. Only the comment needs a quick fix.

   Fix (Fix spelling of "noise" in the comment.):
   includeResults: ['skipped', 'fail', 'flaky'], // skip pass to reduce noise

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

github-actions · 2026-06-10T15:48:18Z

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

sonarqubecloud · 2026-06-10T16:14:23Z

Quality Gate passed for 'open-metadata-ui'

Issues
1488 New issues
0 Accepted issues

Measures
26 Security Hotspots
0.0% Coverage on New Code
3.6% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-06-10T18:26:20Z

🟡 Playwright Results — all passed (22 flaky)

✅ 4262 passed · ❌ 0 failed · 🟡 22 flaky · ⏭️ 88 skipped

Shard	Passed	Flaky	Skipped
🟡 Shard 1	300	1	4
🟡 Shard 2	803	3	9
🟡 Shard 3	805	3	8
🟡 Shard 4	840	3	12
🟡 Shard 5	715	6	47
🟡 Shard 6	799	6	8

🟡 22 flaky test(s) (passed on retry)

Features/CustomizeDetailPage.spec.ts › Domain - customization should work (shard 1, 1 retry)
Features/ColumnBulkOperations.spec.ts › should select column, open drawer, and verify form fields (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 2 retries)
Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
Flow/IngestionBot.spec.ts › Ingestion bot should be able to access domain specific domain (shard 3, 1 retry)
Flow/ObservabilityAlerts.spec.ts › Test case alert (shard 4, 1 retry)
Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 4, 1 retry)
Pages/DataProductAndSubdomains.spec.ts › Search data products by name (shard 4, 1 retry)
Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
Pages/ExplorePageRightPanel.spec.ts › Should perform CRUD and Removal operations for dashboardDataModel (shard 5, 1 retry)
Pages/ExplorePageRightPanel.spec.ts › Should perform CRUD and Removal operations for searchIndex (shard 5, 1 retry)
Pages/ExplorePageRightPanel.spec.ts › Should display and verify schema fields for dashboardDataModel (shard 5, 1 retry)
Pages/ExplorePageRightPanel.spec.ts › validates visible/hidden tabs and tab content for dashboardDataModel (shard 5, 1 retry)
Pages/ExplorePageRightPanel.spec.ts › Should handle lineage expansion buttons for searchIndex (shard 5, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for table -> topic (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage service type filter selection (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
Pages/ServiceEntity.spec.ts › Tier Add, Update and Remove (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Update playwright.config.ts

c7d494f

chirag-madlani requested a review from a team as a code owner June 10, 2026 15:45

github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jun 10, 2026

gitar-bot Bot reviewed Jun 10, 2026

View reviewed changes

chirag-madlani temporarily deployed to test June 10, 2026 15:57 — with GitHub Actions Inactive

chirag-madlani temporarily deployed to test June 10, 2026 15:58 — with GitHub Actions Inactive

chirag-madlani enabled auto-merge (squash) June 10, 2026 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update playwright.config.ts#28931

Update playwright.config.ts#28931
chirag-madlani wants to merge 1 commit into
mainfrom
feat/playwright-reports

chirag-madlani commented Jun 10, 2026 •

edited by gitar-bot Bot

Loading

Uh oh!

gitar-bot Bot Jun 10, 2026

Uh oh!

gitar-bot Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

sonarqubecloud Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

chirag-madlani commented Jun 10, 2026 • edited by gitar-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

Summary by Gitar

Uh oh!

gitar-bot Bot Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

❌ PR checklist incomplete

Uh oh!

sonarqubecloud Bot commented Jun 10, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

github-actions Bot commented Jun 10, 2026

🟡 Playwright Results — all passed (22 flaky)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chirag-madlani commented Jun 10, 2026 •

edited by gitar-bot Bot

Loading