Skip to content

Refactor: Move Data Access Request Button Logic from OSS to Collate#28924

Open
anuj-kumary wants to merge 7 commits into
mainfrom
anuj/dar-button-move
Open

Refactor: Move Data Access Request Button Logic from OSS to Collate#28924
anuj-kumary wants to merge 7 commits into
mainfrom
anuj/dar-button-move

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Jun 10, 2026

Copy link
Copy Markdown
Member

Describe your changes:

Move Data Access Request Button Logic from OSS to Collate

Fixes #28922

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Refactoring:
    • Delegated RequestDataAccess banner and button rendering to TableClassBase to support extension via Collate.
    • Updated DataAssetsHeader to invoke these methods from tableClassBase.
  • Testing:
    • Updated DataAssetsHeader.test.tsx to verify delegation to TableClassBase for banner and button rendering.

This will update automatically on new commits.

@anuj-kumary anuj-kumary self-assigned this Jun 10, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner June 10, 2026 11:50
@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.68% (67038/106951) 43.82% (36874/84138) 46% (11260/24475)

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (12 flaky)

✅ 4272 passed · ❌ 0 failed · 🟡 12 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 297 0 4 4
✅ Shard 2 806 0 0 9
🟡 Shard 3 805 0 3 8
🟡 Shard 4 840 0 3 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 804 0 1 8
🟡 12 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Domain - customization should work (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Validate Glossary Term details page after customization of tabs (shard 1, 1 retry)
  • Features/TeamsHierarchy.spec.ts › Delete Parent Team (shard 1, 1 retry)
  • Pages/Roles.spec.ts › Roles page should work properly (shard 1, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 2 retries)
  • Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should show "Active recently" for users active within last hour (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Email (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Time (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 2 retries)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Merge branch 'main' into anuj/dar-button-move
@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Refactors the Data Access Request button logic by relocating it from OSS to Collate. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Data Access Request Button Logic from OSS to Collate

2 participants