Refactor: Move Data Access Request Button Logic from OSS to Collate#28924
Open
anuj-kumary wants to merge 7 commits into
Open
Refactor: Move Data Access Request Button Logic from OSS to Collate#28924anuj-kumary wants to merge 7 commits into
anuj-kumary wants to merge 7 commits into
Conversation
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
…etadata into anuj/dar-button-move
Contributor
Contributor
🟡 Playwright Results — all passed (12 flaky)✅ 4272 passed · ❌ 0 failed · 🟡 12 flaky · ⏭️ 88 skipped
🟡 12 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Merge branch 'main' into anuj/dar-button-move
Code Review ✅ ApprovedRefactors the Data Access Request button logic by relocating it from OSS to Collate. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
chirag-madlani
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Move Data Access Request Button Logic from OSS to Collate
Fixes #28922
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
RequestDataAccessbanner and button rendering toTableClassBaseto support extension via Collate.DataAssetsHeaderto invoke these methods fromtableClassBase.DataAssetsHeader.test.tsxto verify delegation toTableClassBasefor banner and button rendering.This will update automatically on new commits.