Skip to content

fix(mcp): remove temp-table lineage refs on 1.12.10 (schema not backported) - #28644

Merged
Vishnuujain merged 1 commit into
1.12.10from
fix/remove-temp-lineage-refs-1.12.10
Jun 2, 2026
Merged

fix(mcp): remove temp-table lineage refs on 1.12.10 (schema not backported)#28644
Vishnuujain merged 1 commit into
1.12.10from
fix/remove-temp-lineage-refs-1.12.10

Conversation

@Vishnuujain

@Vishnuujain Vishnuujain commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Problem

OM 1.12.10 doesn't compile. GetLineageTool references TempLineageTable, but the schema that generates it (#26487) was never backported to 1.12.10 (intentional — no 1.13 UI, per @ulixius9).

GetLineageTool.java:[22,36] cannot find symbol: class TempLineageTable

Breaks every build on 1.12.10 (OM #28636) and Collate builds pulling the OM submodule (#4380).

Fix

Remove the temp-table-lineage refs from GetLineageTool and its test. No schema changed → no codegen needed.

Verification

  • mvn clean install -DskipTests -pl '!openmetadata-ui' → BUILD SUCCESS
  • GetLineageToolTest: 8/8 pass

main is unaffected.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes unreachable TempLineageTable references in GetLineageTool to fix compilation failures on the 1.12.10 branch. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@Vishnuujain Vishnuujain added the safe to test Add this label to run secure Github workflows on PRs label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@Vishnuujain
Vishnuujain merged commit 9c7abdc into 1.12.10 Jun 2, 2026
50 of 60 checks passed
@Vishnuujain
Vishnuujain deleted the fix/remove-temp-lineage-refs-1.12.10 branch June 2, 2026 16:48
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 15 failure(s), 23 flaky

✅ 3452 passed · ❌ 15 failed · 🟡 23 flaky · ⏭️ 97 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 2 708 0 2 9
🟡 Shard 3 713 0 10 6
🔴 Shard 4 717 9 4 19
🔴 Shard 5 666 6 1 35
🟡 Shard 6 648 0 6 28

Genuine Failures (failed on all attempts)

Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5)
�[31mTest timeout of 60000ms exceeded.�[39m
🟡 23 flaky test(s) (passed on retry)
  • Features/ColumnBulkOperations.spec.ts › should search columns with server-side API call (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should move term with children to different glossary (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/Permissions/ServiceEntityPermissions.spec.ts › SearchIndex Service allow common operations permissions (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/TestSuiteMultiPipeline.spec.ts › TestSuite multi pipeline support (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Flow/Metric.spec.ts › verify metric expression update (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Flow/ServiceForm.spec.ts › Verify SSL cert upload with long filename and UI overflow handling (shard 3, 1 retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Time (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Set & Update all CP types on apiEndpoint (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Hyperlink (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Delete Stored Procedure (shard 4, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify LineageSearchSelect in lineage mode (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Api Service (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Mlmodel Service (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Search Index Service (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Storage Service (shard 6, 1 retry)
  • Pages/Tag.spec.ts › Add and Remove Assets and Check Restricted Entity (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants