Chore(Ui): Fix flakiness in custom property playwrights#25733
Open
aniketkatkar97 wants to merge 1 commit intomainfrom
Open
Chore(Ui): Fix flakiness in custom property playwrights#25733aniketkatkar97 wants to merge 1 commit intomainfrom
aniketkatkar97 wants to merge 1 commit intomainfrom
Conversation
Code Review ✅ ApprovedClean, well-targeted test reliability fixes. The changes correctly address flaky test issues: replacing uuid with timestamp-based naming for ordering, adding proper Playwright API response waits before assertions, sequencing API calls to prevent server-side conflicts, and standardizing loader wait utilities. No bugs or concerns identified. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates the Playwright test suite for custom properties, focusing on improving test reliability and handling of custom property creation and advanced search scenarios. The most important changes include switching to timestamp-based property naming to avoid conflicts, updating API call handling for custom property creation, and improving page load synchronization in tests.
Test reliability improvements:
Replaced the use of
uuid()withDate.now()for generating custom property names in bothCustomproperties-part1.spec.tsandCustomproperties-part2.spec.tsto ensure unique names and prevent conflicts during parallel test execution. [1] [2] [3] [4] [5] [6] [7] [8]Removed the unused
uuidimport from test files after switching to timestamp-based naming. [1] [2]Advanced search and custom property creation enhancements:
CustomPropertyDetailsinterface to support custom property configs with column lists, enabling more flexible property definitions.Test synchronization and reliability improvements:
waitForAllLoadersToDisappearutility function for better reliability in entity panel navigation and summary panel opening. [1] [2] [3]