Skip to content

Chore(Ui): Fix flakiness in custom property playwrights#25733

Open
aniketkatkar97 wants to merge 1 commit intomainfrom
fix-cp-playwright
Open

Chore(Ui): Fix flakiness in custom property playwrights#25733
aniketkatkar97 wants to merge 1 commit intomainfrom
fix-cp-playwright

Conversation

@aniketkatkar97
Copy link
Member

This pull request updates the Playwright test suite for custom properties, focusing on improving test reliability and handling of custom property creation and advanced search scenarios. The most important changes include switching to timestamp-based property naming to avoid conflicts, updating API call handling for custom property creation, and improving page load synchronization in tests.

Test reliability improvements:

  • Replaced the use of uuid() with Date.now() for generating custom property names in both Customproperties-part1.spec.ts and Customproperties-part2.spec.ts to ensure unique names and prevent conflicts during parallel test execution. [1] [2] [3] [4] [5] [6] [7] [8]

  • Removed the unused uuid import from test files after switching to timestamp-based naming. [1] [2]

Advanced search and custom property creation enhancements:

  • Updated the CustomPropertyDetails interface to support custom property configs with column lists, enabling more flexible property definitions.
  • Refactored the advanced search test setup to sequentially execute API calls for custom property creation and directly assign created property data, avoiding issues with simultaneous requests and simplifying the data mapping logic.

Test synchronization and reliability improvements:

  • Improved test synchronization by explicitly waiting for relevant API responses and selectors when verifying custom property persistence after a page reload, ensuring tests only proceed when the UI is ready.
  • Replaced direct loader selector waits with the waitForAllLoadersToDisappear utility function for better reliability in entity panel navigation and summary panel opening. [1] [2] [3]

@gitar-bot
Copy link

gitar-bot bot commented Feb 6, 2026

Code Review ✅ Approved

Clean, well-targeted test reliability fixes. The changes correctly address flaky test issues: replacing uuid with timestamp-based naming for ordering, adding proper Playwright API response waits before assertions, sequencing API calls to prevent server-side conflicts, and standardizing loader wait utilities. No bugs or concerns identified.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.84% (56032/85108) 45.18% (29334/64923) 47.95% (8848/18454)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant