-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix flaky lienage specs #24893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky lienage specs #24893
Conversation
|
🔍 CI failure analysis for 1ea2095: Glossary async delete test fails because entity not found during bulk delete operation.IssueThe Playwright test Root CauseThe test expects to see the message "Delete operation initiated" when performing bulk deletes, but instead receives an error: This indicates the glossary entity no longer exists when the delete operation attempts to process it. DetailsError Location: Line 158 in Expected behavior: await expect(page.getByTestId('alert-bar')).toHaveText(/Delete operation initiated/i)Actual behavior: Alert bar shows "glossary instance for [name] not found" error Test attempted: At line 1492 in Failure pattern:
Potential Causes
SolutionThe fix should address the race condition in the async delete test by:
Code Review ✅ ApprovedClean test reliability improvements for Playwright E2E tests with proper async patterns. What Works Well
The changes follow Playwright best practices for async handling and should make the E2E tests more reliable. Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
* ui: fix infinite loader issue in lineage section * nit * fix failing sonar * nit * Fix flaky lienage specs (#24893) * chore(ui): handle description render common with util * fix lint error * fix unit tests * fix unit tests * add license to new file * fix unit tests * address copilot comments and if metric spec failure * fix unit tests * fix flaky domain spec failure * fix domain spec issue * remove afterAll block as not required * fix(test): lineage spec failure for AUT * fix certification test issue * fix api wait issue on reload * fix tour spec --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
* ui: fix infinite loader issue in lineage section * nit * fix failing sonar * nit * Fix flaky lienage specs (#24893) * chore(ui): handle description render common with util * fix lint error * fix unit tests * fix unit tests * add license to new file * fix unit tests * address copilot comments and if metric spec failure * fix unit tests * fix flaky domain spec failure * fix domain spec issue * remove afterAll block as not required * fix(test): lineage spec failure for AUT * fix certification test issue * fix api wait issue on reload * fix tour spec --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> (cherry picked from commit 6e582da)



Describe your changes:
Fixes
I worked on ... because ...
Summary by Gitar
descriptionTableObject()insrc/utils/TableColumn.util.tsxprovides reusable description column configuration for table componentsperformZoomOut()for viewport visibility and replacingwaitForTimeout()withwaitForResponse()for proper async handlingdescriptionTableObject()utility covering edge cases and integration scenariosThis will update automatically on new commits.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>