-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ui: add lineage section in overview tab in right panel #24768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.tsx
Outdated
Show resolved
Hide resolved
.../src/main/resources/ui/src/components/Explore/EntitySummaryPanel/EntitySummaryPanel.test.tsx
Outdated
Show resolved
Hide resolved
🔍 CI failure analysis for 6da27d3: Positive Progress: Jobs 1-4/6 now passing! Only jobs 5/6 and 6/6 still failing with the established timeout patternCI Status Update: Significant ProgressCurrent Status (Job 58387879075)Good News:
This is significant progress! Jobs 1-4 are now passing, suggesting either:
Remaining Failures in Job 6/6Job 58387879075 (6/6) shows the same failure pattern as previously analyzed:
Error Pattern (Unchanged): Root Cause (Same as Previously Documented)The failures in jobs 5/6 and 6/6 are caused by async lineage fetching for 15+ entity types. The LineageSection component delays page rendering, causing:
Why Jobs 1-4 Now PassPossible reasons (would need to verify):
Remaining WorkTo resolve the remaining failures in jobs 5/6 and 6/6: Option 1: Extend Fixes to All JobsIf jobs 1-4 were fixed with increased timeouts or mocks, apply the same approach to jobs 5/6 and 6/6: // playwright.config.ts or test setup
export default {
timeout: 90000, // Increased timeout
expect: {
timeout: 15000 // Increased from 5000
}
};
// Mock lineage API for all tests
test.beforeEach(async ({ page }) => {
await page.route('**/api/v1/lineage/**', route => {
route.fulfill({
status: 200,
body: JSON.stringify({ nodes: {}, upstreamEdges: {}, downstreamEdges: {} })
});
});
});Option 2: Fix Spreadsheet TypeErrorThe Spreadsheet version page error suggests defensive null checking is needed: // In EntityVersion or related component
const entityName = lineageData?.entity?.name ?? entity?.name ?? 'Unknown';
// Instead of:
const entityName = lineageData.entity.name; // Throws if undefinedOption 3: Defer Lineage for Specific Scenarios// Don't fetch lineage in version history views
if (activeTab === EntityRightPanelTab.OVERVIEW && !isVersionView) {
fetchLineageData();
}SummaryProgress: 4 out of 6 playwright jobs now passing ✅ Remaining Issues: Jobs 5/6 and 6/6 with same timeout pattern Impact Reduced: From 50+ failing tests across 6 jobs down to remaining failures in 2 jobs Next Steps:
Conclusion: The PR is progressing toward CI success. Once the approach that fixed jobs 1-4 is applied to the remaining jobs, all tests should pass. Code Review 👍 Approved with suggestionsWell-structured feature addition with comprehensive test coverage; previous race condition finding has been addressed. Suggestions 💡 1 suggestionCode Quality: Non-null assertion still used for fullyQualifiedName📄 openmetadata-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.tsx:203 The code at line 203 (in the new This is technically safe due to the guard, but using getUpstreamDownstreamNodesEdges(
edges,
nodes,
dataAsset.fullyQualifiedName as string // or dataAsset.fullyQualifiedName ?? ''
);This is a minor style concern since the guard protects against the null/undefined case. Resolved ✅ 1 resolvedEdge Case: Potential race condition in fetchLineageData on entity change
What Works Well
Recommendations
Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|
|
Changes have been cherry-picked to the 1.11.4 branch. |
* ui: add lineage section in overview tab in right panel * add tests * fix failing tests * fix loader * add tests around loader * fix failing specs * fix loader issue * address copilot comment * address comments * fix infinite loader issue * address comments (cherry picked from commit 6d953d8)
* ui: add lineage section in overview tab in right panel * add tests * fix failing tests * fix loader * add tests around loader * fix failing specs * fix loader issue * address copilot comment * address comments * fix infinite loader issue * address comments



Describe your changes:
Fixes #20835
I worked on adding lineage section in overview tab of project explorer card
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
LineageSectiondisplays upstream/downstream counts with loading and empty states using MUI v7 componentsEntitySummaryPanelwith race condition handling and stale data preventionTABLE,TOPIC,DASHBOARD,PIPELINE,API_ENDPOINT, and drive assetsRightEntityPanelFlow.spec.tsno-lineage-availabletranslation key across 17 language filesThis will update automatically on new commits.