Skip to content

Conversation

@harshsoni2024
Copy link
Contributor

@harshsoni2024 harshsoni2024 commented Dec 4, 2025

Describe your changes:

Fixed for csv parsing format errors.
Added additonal logging for parquet files possible errors.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

TeddyCr
TeddyCr previously approved these changes Dec 9, 2025
@harshsoni2024 harshsoni2024 force-pushed the datalake_csv_fallback_support branch from 6089f35 to 00664a4 Compare December 9, 2025 20:51
@harshsoni2024 harshsoni2024 changed the base branch from 1.7.7 to main December 9, 2025 20:51
@harshsoni2024 harshsoni2024 dismissed TeddyCr’s stale review December 9, 2025 20:51

The base branch was changed.

@harshsoni2024 harshsoni2024 changed the title FIx: add dsv formats fallback support FIx: csv parsing format errors, additonal logging for parquet files Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.98% (50456/78864) 41.39% (24395/58935) 44.95% (7722/17179)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@ayush-shah
Copy link
Member

As discussed with @harshsoni2024 the tests failures are not related to PR, merging it in

@ayush-shah ayush-shah merged commit 300397c into main Dec 10, 2025
33 of 43 checks passed
@ayush-shah ayush-shah deleted the datalake_csv_fallback_support branch December 10, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants