-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix Glossary term circular reference issue with csv import #24571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sonika-shah
merged 2 commits into
main
from
fix-glossaryterm-circular-ref-isue-by-csv-import
Nov 28, 2025
Merged
Fix Glossary term circular reference issue with csv import #24571
sonika-shah
merged 2 commits into
main
from
fix-glossaryterm-circular-ref-isue-by-csv-import
Nov 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-3005
previously approved these changes
Nov 27, 2025
|
yan-3005
approved these changes
Nov 28, 2025
Contributor
|
Changes have been cherry-picked to the 1.11.0 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
* Fix Glossary term circular reference issue with csv import * Fix test (cherry picked from commit 2d01015)
sonika-shah
added a commit
that referenced
this pull request
Dec 1, 2025
* Fix Glossary term circular reference issue with csv import * Fix test
Contributor
Author
|
Changes have been cherry-picked to the 1.10.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
safe to test
Add this label to run secure Github workflows on PRs
To release
Will cherry-pick this PR into the release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Fixes Glossary term circular reference issue with csv import
Issue
CSV import allowed creating glossary terms with circular self-references where a term could be set as its own parent. This occurred because:
csv.name1". The existing validateHierarchy() method only checked UUID and FQN equality, which didn't match in this case, allowing the circular reference to be created.
making it difficult to identify and fix the issue.
Fix
When dryRun=true
Screen.Recording.2025-11-27.at.1.36.50.PM.mov
When dryRun=false
42["csvImportChannel","{\"jobId\":\"a0b7790a-0d6f-4a47-a4d0-85201f6d9128\",\"status\":\"COMPLETED\",\"result\":{\"dryRun\":false,\"status\":\"partialSuccess\",\"numberOfRowsProcessed\":4,\"numberOfRowsPassed\":3,\"numberOfRowsFailed\":1,\"importResultsCsv\":\"status,details,parent,name*,displayName,description,synonyms,relatedTerms,references,tags,reviewers,owner,glossaryStatus,color,iconURL,extension\\r\\nfailure,Invalid hierarchy: Term 'Test csv.name1' cannot be its own parent,Test csv.name1,name1,name1,<p>name1<\/p>,,,,,,user:admin,Approved,,,\\r\\nsuccess,Entity updated,,parent,parent,<p>parent<\/p>,,,,,,user:admin,Approved,,,\\r\\nsuccess,Entity updated,Test csv.parent,child,child,<p>child<\/p>,,,,,,user:admin,Approved,,,\\r\\n\"},\"error\":null}"]Type of change:
Checklist:
Fixes <issue-number>: <short explanation>