Fix(UI): Removed Translation from Constant Files #24570

dhruvjsx · 2025-11-27T07:39:32Z

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions · 2025-11-27T07:39:54Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Pull request overview

This PR removes hardcoded translation calls (t() and i18n.t()) from constant files, converting them to store translation keys instead. Components now handle translation at render time using a new translateLabel utility function for nested translations. This improves internationalization by delaying translation until runtime and supporting dynamic language switching.

Key changes:

Added translateLabel() utility for nested translation parameter handling
Converted constant files to store translation keys instead of translated strings
Updated component logic to translate keys at render time
Extended type definitions to support translation parameters in constants

Reviewed changes

Copilot reviewed 61 out of 62 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`utils/i18next/LocalUtil.ts`	Added `translateLabel()` function for nested translation support
`constants/service-guide.constant.ts`	Removed `i18n.t()` calls, added `titleData`/`descriptionData` fields
`constants/Services.constant.ts`	Changed `servicesDisplayName` to store translation keys with entity parameters
`constants/PageHeaders.constant.ts`	Converted headers/subheaders to keys with optional parameter objects
`constants/Widgets.constant.ts`	Converted widget filter options to translation keys
`constants/BulkImport.constant.ts`	Removed `i18n.t()` and `startCase()`, store translation keys directly
`constants/Task.constant.ts`	Removed `i18n.t()` from task type messages
`constants/Query.constant.ts`	Converted sort options to translation keys
`constants/SearchSettings.constant.ts`	Converted settings labels to translation keys
`constants/Alerts.constants.tsx`	Converted contract status options to translation keys
`constants/AdvancedSearch.constants.ts`	Added `labelKeyOptions` for nested translations
`constants/Applications.constant.ts`	Converted stepper steps to translation keys
`interface/types.d.ts`	Added optional `nameData`, `titleData`, `descriptionData` fields
`components/PageHeader/*`	Updated to use `translateLabel()` for headers with parameters
`components/SearchDropdown/*`	Added `labelKeyOptions` prop for nested translations
`components/Explore/*`	Updated to pass translation keys and translate in components
`components/Settings/Services/*`	Updated service name translation logic
`components/SearchSettings/*`	Updated to translate labels at render time
`components/DataInsight/*`	Converted headers to use translation keys
`components/DataQuality/*`	Updated to use translation keys
`components/MyData/Widgets/*`	Updated sort options to translate at render time
`pages/IncidentManager/*`	Updated to translate page headers
Test files (multiple)	Added `translateLabel` to i18n mocks

Copilot · 2025-11-27T07:55:32Z

openmetadata-ui/src/main/resources/ui/src/constants/service-guide.constant.ts

+    description: 'message.ingestion-pipeline-name-successfully-deployed-entity',
+    descriptionData: { entity: 'label.metadata-lowercase' },


The descriptionData field is used in the service guide constants (e.g., lines 41, 60, 79, 96, 113) but there's no type definition for it. The service guide objects should have a type that includes both titleData and descriptionData as optional fields to ensure type safety.

Since I didn't see this constent being used anywhere I didn't add type for it. Cleaning up was not objective of this PR

Copilot · 2025-11-27T07:55:32Z

openmetadata-ui/src/main/resources/ui/src/utils/i18next/LocalUtil.ts

+export const translateLabel = (
+  label: string,
+  params?: Record<string, string | number | boolean>
+): string => {
+  if (!params) {
+    return t(label);
+  }
+
+  const translatedParams = Object.entries(params).reduce(
+    (acc, [key, value]) => ({
+      ...acc,
+      [key]: typeof value === 'string' ? t(value) : value,
+    }),
+    {}
+  );
+
+  return t(label, translatedParams);
+};


[nitpick] The translateLabel function type definition allows string | number | boolean for parameter values, but the implementation only translates string values with t(). Non-string values are passed through directly. Consider documenting this behavior or adding type safety to ensure only translation keys (strings) are translated while numbers/booleans are passed through as-is.

github-actions · 2025-11-27T08:16:38Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	63.45% (49766/78429)	40.61% (23801/58615)	44.32% (7568/17074)

...i/src/main/resources/ui/src/components/DataInsight/DataAssetsTab/DataAssetsTab.component.tsx

openmetadata-ui/src/main/resources/ui/src/components/DataInsight/KPIChart.tsx

chirag-madlani · 2025-11-28T09:54:34Z

...c/main/resources/ui/src/components/Settings/Services/AddIngestion/AddIngestion.component.tsx

+    () =>
+      STEPS_FOR_ADD_INGESTION.map((step) => ({
+        ...step,
+        name: translateLabel(step.name, step.nameData),


We can use t from hook here no?

chirag-madlani · 2025-11-28T09:55:50Z

...adata-ui/src/main/resources/ui/src/components/common/EntityImport/EntityImport.component.tsx

+    () =>
+      STEPS_FOR_IMPORT_ENTITY.map((step) => ({
+        ...step,
+        name: startCase(t(step.name)),


Why startCase to step? Must we fix it in thelanguage file no?

It was part of constant file

chirag-madlani · 2025-11-28T09:59:15Z

openmetadata-ui/src/main/resources/ui/src/interface/types.d.ts


  export type StepperStepType = {
    name: string;
+    nameData?: Record<string, string | number | boolean>;


Why we need this?

chirag-madlani · 2025-11-28T09:59:37Z

openmetadata-ui/src/main/resources/ui/src/pages/AddServicePage/AddServicePage.component.tsx

 import { getServiceLogo } from '../../utils/CommonUtils';
 import { getEntityFeedLink } from '../../utils/EntityUtils';
 import { handleEntityCreationError } from '../../utils/formUtils';
+import { translateLabel } from '../../utils/i18next/LocalUtil';


Why we have this translateLabel? we can use t directly no?

For nested Translation we can't directly remove t from constant file. That's why needed to divide translation into two part like name and nameData . Created a util function translateLabel which will accept both the keys and translate them properly.

openmetadata-ui/src/main/resources/ui/src/utils/i18next/LocalUtil.ts

…vjsx/OpenMetadata into remove-translation-constant

sonarqubecloud · 2025-11-28T11:57:07Z

Quality Gate passed for 'open-metadata-ui'

Issues
150 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-12-01T05:28:57Z

Changes have been cherry-picked to the 1.11.0 branch.

* removed translation from constant files * fixed missing header params * fixed pageheader translation * fixed search dropdown * fixed datainsightchard * fixed sorting dropdown * fixed data asset tab * fixed data asset tab * fixed ingestion stepper * minor fixes and undo changes from unused file * fixed widget constants * removed unused mocks from tests * removed translation from policy * renamed translateLabel--> translateWithNestedKeys (cherry picked from commit b8eabae)

Ashish8689 · 2025-12-01T05:56:13Z

Changes have been cherry-picked to the 1.10.11 branch as well.

removed translation from constant files

8090283

dhruvjsx requested a review from a team as a code owner November 27, 2025 07:39

dhruvjsx had a problem deploying to test November 27, 2025 07:39 — with GitHub Actions Failure

dhruvjsx changed the title ~~Fix(UI): Removed Translastion from Constant Files~~ Fix(UI): Removed Translation from Constant Files Nov 27, 2025

Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Nov 27, 2025

Ashish8689 temporarily deployed to test November 27, 2025 07:50 — with GitHub Actions Inactive

Ashish8689 had a problem deploying to test November 27, 2025 07:50 — with GitHub Actions Failure

Ashish8689 requested a review from Copilot November 27, 2025 07:51

Copilot started reviewing on behalf of Ashish8689 November 27, 2025 07:52 View session

Copilot finished reviewing on behalf of Ashish8689 November 27, 2025 07:54

Copilot AI reviewed Nov 27, 2025

View reviewed changes

fixed missing header params

6765f2e

dhruvjsx had a problem deploying to test November 27, 2025 10:05 — with GitHub Actions Failure

removed translation from policy

73aef9a

dhruvjsx had a problem deploying to test November 28, 2025 09:37 — with GitHub Actions Error

Merge branch 'main' into remove-translation-constant

3519a7a

dhruvjsx had a problem deploying to test November 28, 2025 09:56 — with GitHub Actions Error

dhruvjsx temporarily deployed to test November 28, 2025 09:56 — with GitHub Actions Inactive

dhruvjsx had a problem deploying to test November 28, 2025 09:56 — with GitHub Actions Error

dhruvjsx temporarily deployed to test November 28, 2025 09:56 — with GitHub Actions Inactive

dhruvjsx had a problem deploying to test November 28, 2025 09:56 — with GitHub Actions Error

chirag-madlani reviewed Nov 28, 2025

View reviewed changes

dhruvjsx added 2 commits November 28, 2025 16:52

renamed translateLabel--> translateWithNestedKeys

d844c89

Merge branch 'remove-translation-constant' of https://github.com/dhru…

efd4987

…vjsx/OpenMetadata into remove-translation-constant

dhruvjsx temporarily deployed to test November 28, 2025 11:29 — with GitHub Actions Inactive

dhruvjsx had a problem deploying to test November 28, 2025 11:29 — with GitHub Actions Failure

dhruvjsx temporarily deployed to test November 28, 2025 11:29 — with GitHub Actions Inactive

chirag-madlani approved these changes Dec 1, 2025

View reviewed changes

chirag-madlani merged commit b8eabae into open-metadata:main Dec 1, 2025
17 of 19 checks passed

		description: 'message.ingestion-pipeline-name-successfully-deployed-entity',
		descriptionData: { entity: 'label.metadata-lowercase' },

Fix(UI): Removed Translation from Constant Files #24570

Fix(UI): Removed Translation from Constant Files #24570

Uh oh!

Conversation

dhruvjsx commented Nov 27, 2025

Describe your changes:

Type of change:

Checklist:

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvjsx Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

Uh oh!

Uh oh!

chirag-madlani Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

chirag-madlani Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvjsx Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

chirag-madlani Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

chirag-madlani Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

dhruvjsx Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 28, 2025

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

Ashish8689 commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 27, 2025 •

edited

Loading