Skip to content

fix custom property failure around data and time formats #24560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ashish8689 merged 4 commits into from
Nov 27, 2025
Merged

fix custom property failure around data and time formats #24560

Ashish8689 merged 4 commits into from
Nov 27, 2025

Conversation

@Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 26, 2025

Describe your changes:

Fixes

  • I worked on fixing custom property around data and time formats, since previous format was moment and after react bump we shifted to Luxon around ATND Component. Which created the issue.
  • Added expect for in playwright test around this type. So failure can be traced in future runs. If they are passing or not.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 self-assigned this Nov 26, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner November 26, 2025 14:21
@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 26, 2025
@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.46% (49686/78291) 40.58% (23760/58556) 44.28% (7533/17013)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit ba7f5eb into main Nov 27, 2025
22 of 24 checks passed
@Ashish8689 Ashish8689 deleted the custom-property-fix branch November 27, 2025 12:11
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Changes have been cherry-picked to the 1.11.0 branch.

github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
@Ashish8689
fix custom property failure around data and time formats (#24560)
cdcd9d3 
* fix custom property failure around data and time formats

* fix the playwright value

* fix the flakyness of serviceForm.spec

(cherry picked from commit ba7f5eb)
Ashish8689 added a commit that referenced this pull request Nov 28, 2025
@Ashish8689
fix custom property failure around data and time formats (#24560)
896c162 
* fix custom property failure around data and time formats

* fix the playwright value

* fix the flakyness of serviceForm.spec

(cherry picked from commit ba7f5eb)
@Ashish8689
Copy link
Contributor Author

Ashish8689 commented Nov 28, 2025

Changes have been cherry-picked to the 1.10.10 branch as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Ashish8689 Ashish8689

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ashish8689 @chirag-madlani