Fixes 404 error when loading dashboards or other entities that reference deleted glossary terms or tags #24340
Conversation
Bhanuagr
added
safe to test
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
Jest test CoverageUI tests summary
|
| c.setTags(new ArrayList<>()); | ||
| } else { | ||
| c.setTags(addDerivedTags(columnTag)); | ||
| c.setTags(addDerivedTagsGracefully(columnTag)); |
There was a problem hiding this comment.
what do you mean by same name ? function name need to be different if same parameters list to pass, right ?
There was a problem hiding this comment.
addDerivedTags we are updating all the occurance
we can still call that addDerivedTags instaed of addDerivedTagsGracefully, it's a minor nit nothing on functionality "Gracefully" can be removed i meant
|
|
Failed to cherry-pick changes to the 1.10.8 branch. |
…nce deleted glossary terms or tags (#24340) * Fixes 404 error when loading dashboards that reference deleted glossary terms * Fixed tests
…nce deleted glossary terms or tags (#24340) * Fixes 404 error when loading dashboards that reference deleted glossary terms * Fixed tests
Root Cause
The error occurs during tag fetching in TagLabelUtil:
These exceptions propagate up through the call stack and cause the entire getByName API to fail.
Solution
Added comprehensive error handling in TagLabelUtil.java to gracefully skip missing glossary terms:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>