Fix chart action buttons enabled state logic #9547
Conversation
Currently, the download and copy-to-clipboard buttons for charts are enabled if any chart exists in the `charts` array (`charts.length > 0`). This causes an issue where buttons for a specific chart are enabled even if that specific chart hasn't been rendered yet, leading to errors or empty downloads. This commit introduces `isChartReady(chartId)` to check if the specific chart exists before enabling the buttons. Test plan: - Manual verification: Check that buttons are disabled until the specific chart is rendered. - Lint: `npm run lint` passes. - Build: `npm run build` passes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Currently, the download and copy-to-clipboard buttons for charts are enabled if any chart exists in the `charts` array (`charts.length > 0`). This causes an issue where buttons for a specific chart are enabled even if that specific chart hasn't been rendered yet, leading to errors or empty downloads. This commit introduces `isChartReady(chartId)` to check if the specific chart exists before enabling the buttons. Test plan: - Manual verification: Check that buttons are disabled until the specific chart is rendered. - Lint: `npm run lint` passes. - Build: `npm run build` passes.
Currently, the download and copy-to-clipboard buttons for charts are enabled if any chart exists in the `charts` array (`charts.length > 0`). This causes an issue where buttons for a specific chart are enabled even if that specific chart hasn't been rendered yet, leading to errors or empty downloads. This commit introduces `isChartReady(chartId)` to check if the specific chart exists before enabling the buttons. Test plan: - Manual verification: Check that buttons are disabled until the specific chart is rendered. - Lint: `npm run lint` passes. - Build: `npm run build` passes.
Fixes a bug where chart action buttons are clickable when the data is not yet ready. The fix involves checking for the existence of the specific chart by ID instead of checking if any chart exists.
PR created automatically by Jules for task 14921036252108764922 started by @uj-sxn