Refactor hardcoded colors to use Material theme system #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Defined CSS custom properties for theme colors in `src/planet-mat-theme.scss`. - Refactored `src/app/shared/utils.ts` to use `getThemeColor` for `styleVariables`. - Updated `src/app/shared/chart-utils.ts` to use theme variables for chart colors and no-data placeholder. - Replaced inline style in `src/app/resources/view-resources/resources-viewer.component.html` with `.text-white` class. - Replaced hardcoded colors in `src/app/manager-dashboard/reports/reports-detail.component.ts` and `src/app/manager-dashboard/manager-fetch.component.ts` with theme variables. - Verified changes with linting and manual code inspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/planet-mat-theme.scss.src/app/shared/utils.tsto usegetThemeColorforstyleVariables.src/app/shared/chart-utils.tsto use theme variables for chart colors and no-data placeholder.src/app/resources/view-resources/resources-viewer.component.htmlwith.text-whiteclass.src/app/manager-dashboard/reports/reports-detail.component.tsandsrc/app/manager-dashboard/manager-fetch.component.tswith theme variables.https://jules.google.com/session/9304652404821053992