Skip to content

Extract large inline templates to separate HTML files #9521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dogi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extract large inline templates to separate HTML files #9521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/app/shared/dialogs/dialogs-announcement-success.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<div class="announcement-container">
<img
src="assets/challenge/dec challenge.jpeg"
alt="Issues Challenge"
class="announcement-banner"
/>
<p class="success-msg">¡Felicidades reto completado!</p>
</div>
11 changes: 1 addition & 10 deletions src/app/shared/dialogs/dialogs-announcement.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,7 @@ export const examId = '4e6b78800b6ad18b4e8b0e1e38b382ab';
export const challengePeriod = (new Date() > new Date(2024, 10, 31)) && (new Date() < new Date(2025, 0, 16));

@Component({
template: `
<div class="announcement-container">
<img
src="assets/challenge/dec challenge.jpeg"
alt="Issues Challenge"
class="announcement-banner"
/>
<p class="success-msg">¡Felicidades reto completado!</p>
</div>
`,
templateUrl: './dialogs-announcement-success.component.html',
styleUrls: [ './dialogs-announcement.component.scss' ]
})
export class DialogsAnnouncementSuccessComponent { }
Expand Down
13 changes: 13 additions & 0 deletions src/app/shared/dialogs/dialogs-submissions.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<h3 mat-dialog-title i18n class="mat-subtitle-1">Review Previous Test Attempts</h3>
<mat-dialog-content>
<planet-submissions *ngIf="view==='list'" [isDialog]="true" [parentId]="data.parentId"
[displayedColumns]="[ 'lastUpdateTime', 'gradeTime', 'grade', 'status' ]" (submissionClick)="showSubmission($event)">
</planet-submissions>
<ng-container *ngIf="view==='submission'">
<planet-exams-view [isDialog]="true" [submission]="submission" [questionNum]="1" mode="view"></planet-exams-view>
</ng-container>
</mat-dialog-content>
<mat-dialog-actions>
<button *ngIf="view==='submission'" mat-stroked-button (click)="showList()" i18n>Back to submission list</button>
<button mat-dialog-close mat-raised-button color="primary" i18n>OK</button>
</mat-dialog-actions>
16 changes: 1 addition & 15 deletions src/app/shared/dialogs/dialogs-submissions.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,7 @@ import { Component, Inject } from '@angular/core';
import { MAT_LEGACY_DIALOG_DATA as MAT_DIALOG_DATA } from '@angular/material/legacy-dialog';

@Component({
template: `
<h3 mat-dialog-title i18n class="mat-subtitle-1">Review Previous Test Attempts</h3>
<mat-dialog-content>
<planet-submissions *ngIf="view==='list'" [isDialog]="true" [parentId]="data.parentId"
[displayedColumns]="[ 'lastUpdateTime', 'gradeTime', 'grade', 'status' ]" (submissionClick)="showSubmission($event)">
</planet-submissions>
<ng-container *ngIf="view==='submission'">
<planet-exams-view [isDialog]="true" [submission]="submission" [questionNum]="1" mode="view"></planet-exams-view>
</ng-container>
</mat-dialog-content>
<mat-dialog-actions>
<button *ngIf="view==='submission'" mat-stroked-button (click)="showList()" i18n>Back to submission list</button>
<button mat-dialog-close mat-raised-button color="primary" i18n>OK</button>
</mat-dialog-actions>
`,
templateUrl: './dialogs-submissions.component.html',
styles: [ `
h3.mat-dialog-title {
margin: 0
Expand Down
Loading