src/app/manager-dashboard/reports/reports-detail.component.ts (fixes #9504) #9517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

Saby-Bishops wants to merge 1 commit into master from codex/fix-defect-in-reports-detail.component.ts

Member

Saby-Bishops commented Jan 22, 2026

Motivation

fixes src/app/manager-dashboard/reports/reports-detail.component.ts #9504: avoid wiping out user-selected or deep-linked custom date ranges when switching the reports time filter to custom, so the UI preserves the intended date range instead of resetting to a default window.

Description

Updated onTimeFilterChange in src/app/manager-dashboard/reports/reports-detail.component.ts to preserve existing this.filter.startDate / this.filter.endDate (or fall back to minDate / a 12-month default) when timeFilter === 'custom', and added an explanatory comment.

Testing

No automated tests were executed for this change (per instructions not to run ./gradlew test).


          fix: preserve custom reports date range

7903a8d

Saby-Bishops added the codex label

— with

ChatGPT Codex Connector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels