manager: smoother reports filter type form (fixes #9504)

[Saby-Bishops]

Motivation

• Improve type safety for the reports date filter form by migrating from untyped Angular forms to typed FormGroup/FormControl/FormBuilder usages.
• Ensure the end-date validation is applied at the group level (so it is not treated as a control) and make date value handling explicit under strict typing.

Description

• Replaced UntypedFormGroup/UntypedFormBuilder imports with typed FormBuilder, FormControl, and FormGroup imports and usages.
• Added a DateFilterForm type alias describing startDate and endDate as FormControl<Date | '' | null> and updated dateFilterForm to FormGroup<DateFilterForm>.
• Reworked initDateFilterForm() to build the group with typed controls using this.fb.control<...>(...) and moved CustomValidators.endDateValidator() into the group options ({ validators: ... }).
• Adjusted valueChanges handling to explicitly treat value.startDate/value.endDate as Date instances (instanceof Date) and otherwise use null, and ensured existing setValue/patchValue interactions reference the typed controls.

Testing

• No automated tests were run for this change (per instruction, ./gradlew test was not executed).

---

Codex Task

[uj-sxn]

The migration to typed forms in this component is a great improvement for long-term maintainability. It makes the expected data structure for the date filters much more explicit and helps prevent runtime errors.

[Copilot]

Pull request overview

This PR enhances type safety in the reports filter form by migrating from untyped Angular forms to strongly typed form controls. The change ensures compile-time type checking for the date filter form and correctly applies end-date validation at the form group level rather than as a control validator.

Changes:

• Replaced UntypedFormGroup/UntypedFormBuilder with typed FormGroup/NonNullableFormBuilder and related imports
• Introduced DateFilterForm interface to define the structure of form controls
• Refactored initDateFilterForm() to use typed form controls with explicit validators and moved group-level validation to the correct position

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.