oio-proxy: free memory to solve oio-proxy memory consumption issue

open-io · Nov 15, 2024 · 6b88370 · 6b88370
1 parent c23105d
commit 6b88370
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/core/ext.c b/core/ext.c
@@ -224,7 +224,7 @@ static void _local_free(gpointer p) {
 		l->perfdata = NULL;
 	}
 	if (l->urlerrorv) {
-		g_ptr_array_free(l->urlerrorv, TRUE);
+		g_ptr_array_unref(l->urlerrorv);
 	}
 	g_free (l);
 }
@@ -473,7 +473,7 @@ GPtrArray *oio_ext_get_urlerrorv(void) {
 void oio_ext_set_urlerrorv(GPtrArray *urlerrorv) {
 	struct oio_ext_local_s *l = _local_ensure();
 	if (l->urlerrorv) {
-		g_ptr_array_free(l->urlerrorv, TRUE);
+		g_ptr_array_unref(l->urlerrorv);
 	}
 	l->urlerrorv = urlerrorv;
 }

diff --git a/proxy/common.c b/proxy/common.c
@@ -567,7 +567,9 @@ gridd_request_replicated (struct req_args_s *args, struct client_ctx_s *ctx,
 	EXTRA_ASSERT(urlv->len == errorv->len);
 
 	if (urlerrorv->len > 0) {
-		oio_ext_set_urlerrorv(urlerrorv);
+		// Increase the reference count
+		GPtrArray *shared_urlerrorv = g_ptr_array_ref(urlerrorv);
+		oio_ext_set_urlerrorv(shared_urlerrorv);
 	}
 
 	g_strfreev(m1uv);
@@ -583,6 +585,8 @@ gridd_request_replicated (struct req_args_s *args, struct client_ctx_s *ctx,
 	FinishArray(ctx->urlv, gchar, urlv);
 	FinishArray(ctx->bodyv, GByteArray, bodyv);
 	FinishArray(ctx->errorv, GError, errorv);
+	// Unreference the urlerrov array
+	g_ptr_array_unref(urlerrorv);
 
 	return err;
 }