Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphan pages checker GHA #159

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

tushar5526
Copy link
Contributor

@tushar5526 tushar5526 commented Feb 18, 2022

Signed-off-by: tushar5526 codingid6@gmail.com

Description

GHA that outputs the orphan pages in GHA logs on same interval as broken link checker.

Fixes #89

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on my forked repo and locally

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Signed-off-by: tushar5526 <codingid6@gmail.com>
@tushar5526
Copy link
Contributor Author

Hey @joewxboy. It was great fun to solve this one.
Can you test this GHA if it is working fine? It's working fine on my fork.

@tushar5526
Copy link
Contributor Author

This gets the job done, but I can also make it such that this action runs whenever we add any specific label to a PR or something like that if there is a need for it.

@joewxboy joewxboy self-requested a review February 18, 2022 21:55
Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the branch is in your personal repo and not open-horizon, I'll have to merge and then test.

@joewxboy joewxboy merged commit e4ad628 into open-horizon:master Feb 18, 2022
@joewxboy
Copy link
Member

This gets the job done, but I can also make it such that this action runs whenever we add any specific label to a PR or something like that if there is a need for it.

Sure, we can add more optimizations, like excluding /404.html and /dir.html but this is an excellent start. Thanks,.

@tushar5526 tushar5526 deleted the orphan-pages-checker branch February 19, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GHA to scan open-horizon.github.io for orphaned pages
2 participants