macOS: Fix issue causing only part of the window to be rendered to #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATerbrack
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fundamental issue is related to hiDPI / Retina displays, I don't think our rendering code is setup properly to handle the scaling between the two (which you can derive by comparing
SDL_GetWindowSizeandSDL_GL_GetDrawableSize).So rather than opening that can of worms, I just removed the window flag.
Also fixed an unrelated issue for displaying resolution options when in windowed mode, it was previously only adding options to the list if they were invalid for full-screen.
Fixes #3099