game: Update game's GPU test to output the GPU vendor info #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xTVaser
force-pushed
the
v/extend-gpu-test
branch
from
3443c4c to
1cc95b6
Compare
xTVaser
added a commit
to open-goal/launcher
that referenced
this pull request
Oct 19, 2024
Fixes #588 Removes wgpu, uses open-goal/jak-project#3717 instead. Tested all 3 scenarios:  > updated gk binary and the gpu test passes  > no active version is selected  > old GK, with no support for outputting the gpu info This is better in several ways, including that it determines the GPU that will actually be used by the game (eliminating guess work on whether the integrated card is being selected or not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so I can get rid of wgpu from the launcher, where it's only purpose is to figure out the GPU name for the support package.
The problem with it is that on some environments, it errors, but the function cannot have it's errors gracefully handled (it panics and crashes instead).
So I'm tired of it, do it ourselves.