d/jak2: finish the majority of sparticle and sparticle-launcher
#1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xTVaser
force-pushed
the
j2/sparticle
branch
from
793d13a to
820ff39
Compare
ManDude
requested changes
Sep 3, 2022
xTVaser
force-pushed
the
j2/sparticle
branch
from
74836c3 to
a545b49
Compare
xTVaser
force-pushed
the
j2/sparticle
branch
from
a545b49 to
b1b28d7
Compare
ManDude
approved these changes
Sep 4, 2022
water111
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Looks good, we're going to have to do a bunch of scratchpad/PC modifications/mips2c stuff.
I think we should wait until textures are working, so you can actually run this stuff and debug things. Let me know if you ware interested in working on this, I think it would be a good way to learn about mips2c stuff if you want.
| (scalevelx float :offset 28) | ||
| (scalevely float :offset 44) | ||
| (friction float :offset-assert 96) | ||
| (timer int32 :offset-assert 100) | ||
| (flags sp-cpuinfo-flag :offset-assert 104) ;; guessed by decompiler | ||
| (flags sp-cpuinfo-flag :offset-assert 104) ;; NOTE - loaded with lw and lwu? |
There was a problem hiding this comment.
probably a sign that one of these is loaded from assembly (where they sometimes used the wrong load by accident, but it doesn't really matter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of the sparticle code remains the same (i wonder why lol) but there are a handful of new functions and effects in
sparticle-launcher-- many of which ive left unfinished because they require essentially guesses at this point (they access arbitrary data). The rest of the functions we used mip2c for in jak 1, which I don't know how to use yet.In some cases in
sparticleit seems like we manually fixed the functions -- likememcpy? Perhaps these should also be mips2c'd this time around?