pull request check

[strantalis]

This pr partially resolves #70 by adding a github action to run npm ci, npm lint and npm build on pull requests to do some basic validation that the site can be built.

[strantalis]

@niklasmtj @chris-short @christianh814 I am not that familiar with how github actions caching is supposed to work so looking for a second set of eyes. Maybe I am just missing something.

When testing this configuration my assumption was I thought I could basically build the cache in the install job then carry it over to the lint and build jobs but that doesn't seem to be the case.

I might have been over complicating it as well. The below action works if we are okay with a single job (tested on my own repo).

name: CI Checks

on:
  pull_request:
    branches:    
      - main

jobs:
  check:
    name: Pull Request Lint/Build
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v2
      - name: Setup Node
        uses: actions/setup-node@v2
        with:
          node-version: '14'
          cache: npm
      - name: Install dependencies
        run: npm ci
      - name: Lint
        run: npm run lint
      - name: Build
        run: npm run build

[niklasmtj]

I think that your posted solution above is a good one. Since the steps are run in sequence and not in parallel (as far as I know) as done in the link you posted. For me your steps look fine. We can be sure that a successful run of the Action will give us a proper Gatsby build.

Do you know why eslint does not work in the Action? I read everywhere that it is locally preinstalled when using setup-node action.

If you need any help going further just hit me up. (Berlin timezone, fyi 😀)

[christianh814]

This LGTM

[scottrigby]

thank you @strantalis and @niklasmtj ❤️