Skip to content

Fix broken links due to repository changes and missing anchors #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottrigby merged 15 commits into from
Feb 14, 2022
Merged

Fix broken links due to repository changes and missing anchors #64

scottrigby merged 15 commits into from
Feb 14, 2022

Conversation

@niklasmtj
Copy link
Member

@niklasmtj niklasmtj commented Feb 9, 2022 •
edited by scottrigby
Loading

This PR resolves #60 which I created a week ago.

This implements all the points I noted in the issue except of the following 2:

So if you want me to also add these to this PR or leave it open for a future PR just let me know. If you need anything more from me just tell me.

@christianh814
Copy link
Member

christianh814 commented Feb 9, 2022

@niklasmtj Can you set the DCO? https://github.com/open-gitops/website/pull/64/checks?check_run_id=5131087848

christianh814
christianh814 reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Fix the DCO issue and I'll approve it.

@christianh814 christianh814 mentioned this pull request Feb 9, 2022
Closed
niklasmtj and others added 8 commits February 10, 2022 07:51
@niklasmtj
Update siteURL and repo to new name
5ce3360 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update charter link on about page
09cfbba 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update working group and committee link
9a554ad 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update meetings link
5e4b539 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update responsible working group in footer
d8dd9c7 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update h2s to include anchor tags to link to
af6b785 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@beasync @niklasmtj
fix(components/events): fix empty events list rendering
ab73ec3 
Signed-off-by: beasync <marco.dsanchez@gmail.com>
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@lloydchang @niklasmtj
docs(get-involved.mdx): Fix gitops-wg repo URL
ce5cc6e 
https://github.com/gitops-working-group/gitops-working-group/
→
https://github.com/cncf/tag-app-delivery/tree/main/gitops-wg

Signed-off-by: lloydchang <lloydchang@gmail.com>
@niklasmtj niklasmtj force-pushed the fix/broken-website-links branch from 78f487b to ce5cc6e Compare February 10, 2022 06:55
@niklasmtj
Copy link
Member Author

niklasmtj commented Feb 10, 2022

@christianh814 I hope everything is fine now. I still haven't used DCOs that much but I should change that in the future. 👍🏼

christianh814
christianh814 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

scottrigby
scottrigby requested changes Feb 10, 2022
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! a few more suggestions

@niklasmtj
Update footer to use WG again instead of TAG
0b69715 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Remove working group project boards point
d8c9960 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Update links to go to gitops-wg sub-dir on GH
f1aedfe 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Add autolinks headers plugin
af0dc55 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Add config for autolink headers plugin
655242d 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Remove custom headline tags from mdx files
2817ab6 
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
@niklasmtj
Copy link
Member Author

niklasmtj commented Feb 14, 2022

@scottrigby everything should be fixed now. Please check again and tell me if something is missing.

@scottrigby
Copy link
Member

scottrigby commented Feb 14, 2022 •
edited
Loading

@niklasmtj thanks for this 💯 looks good!

Re your two questions above:

YES, please remove those dummy press releases. Thank you! We are currently using the blog for press release purposes as well as other future content.

Yes please update this, thank you.

Ideally, the website would pull from canonical files in other repos in this GitHub org. For now, let's please just make sure any updates to this kind of content on the website has corresponding updates in the canonical source files.

That canonical source for the content from that page is currently here https://github.com/cncf/tag-app-delivery/tree/main/gitops-wg#community.

I'll merge this PR now, and these can be done in follow-up PRs. Thanks!

@scottrigby scottrigby merged commit 2040d60 into open-gitops:main Feb 14, 2022
@scottrigby
Copy link
Member

scottrigby commented Feb 14, 2022

@niklasmtj deploy action has failed. Are you able to look into this error? https://github.com/open-gitops/website/runs/5186973902?check_suite_focus=true

@niklasmtj niklasmtj deleted the fix/broken-website-links branch February 14, 2022 17:16
@niklasmtj niklasmtj restored the fix/broken-website-links branch February 14, 2022 17:17
@niklasmtj
Copy link
Member Author

niklasmtj commented Feb 14, 2022

Oh I see. Yeah will look into this. I think it is because the site is being built with npm and I used yarn for it. But can change to npm no problem. Will open a new PR for it with the updated .lock files which should work.

This was referenced Feb 14, 2022
Merged
Merged
@scottrigby
Copy link
Member

scottrigby commented Feb 14, 2022

Thanks @niklasmtj 👏 for anyone following along:

@niklasmtj niklasmtj mentioned this pull request Feb 15, 2022
Open
@niklasmtj niklasmtj mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottrigby scottrigby scottrigby approved these changes

@christianh814 christianh814 christianh814 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken links on the website due to repository name changes

5 participants

@niklasmtj @christianh814 @scottrigby @beasync @lloydchang