Add Github Pages deploy workflow #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a Github action using the "peaceiris/actions-gh-pages" action step to deploy to Github pages Signed-off-by: Nicholas Thomson <nithomso@amazon.com>
scottrigby
requested changes
Aug 24, 2021
Member
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
@RedbackThomson thanks for this PR!
Quick untested review lgtm 👀 👌 per https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-gatsby
Check out my CNAME comment. The line breaks are minor but may as well clean those up.
I'd say let's get this fixed and merge/test it! If there's any issue we can simply revert the PR and try again. But it would be really good to automate the deploy, as we're currently busy with other things and this will help the site run smoothly.
Contributor
Author
|
Thanks @scottrigby . Updated! Also, I tested this on my private fork and ensured it produced the same output as the current site. |
Member
|
@RedbackThomson nice! Just need to fix DCO (see https://github.com/open-gitops/website/pull/30/checks) |
Signed-off-by: Nicholas Thomson <nithomso@amazon.com>
scottrigby
approved these changes
Aug 24, 2021
todaywasawesome
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Add deploy workflow Create a Github action using the "peaceiris/actions-gh-pages" action step to deploy to Github pages Signed-off-by: Nicholas Thomson <nithomso@amazon.com> * Whitespace fixes Signed-off-by: Nicholas Thomson <nithomso@amazon.com> Signed-off-by: Dan Garfield <dan@codefresh.io>
scottrigby
added a commit
that referenced
this pull request
Nov 8, 2021
* Updated website to be compliant with CNCF guidelines (#33) * Changed founding members to be in alphabetical order Signed-off-by: Roberth Strand <me@robstr.dev> * Added LF Trademark footer Signed-off-by: Roberth Strand <me@robstr.dev> Signed-off-by: Dan Garfield <dan@codefresh.io> * Add Github Pages deploy workflow (#30) * Add deploy workflow Create a Github action using the "peaceiris/actions-gh-pages" action step to deploy to Github pages Signed-off-by: Nicholas Thomson <nithomso@amazon.com> * Whitespace fixes Signed-off-by: Nicholas Thomson <nithomso@amazon.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * GitOpsCon NA 20201 Blog (#34) Signed-off-by: Christian Hernandez <chernand@redhat.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * create gitops-one-stop-shop event (#36) * create gitops-one-stop-shop event * add mdx file extension Signed-off-by: Stacey Potter <50154848+staceypotter@users.noreply.github.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Remove link to nonexistent fb page (#38) * Remove link to nonexistent fb page Signed-off-by: Scott Rigby <scott@r6by.com> * Remove fb page icon Co-authored-by: Nicholas Thomson <RedbackThomson@users.noreply.github.com> Signed-off-by: Scott Rigby <scott@r6by.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * initial commit to create blog post Signed-off-by: Dan Garfield <dan@codefresh.io> * Add blogpost Signed-off-by: Dan Garfield <dan@codefresh.io> * Remove announcements around white papers etc... Signed-off-by: Dan Garfield <dan@codefresh.io> * Link to v1.0.0 ref not main Signed-off-by: Scott Rigby <scott@r6by.com> * Fix formatting: list and extra break/trailing whitespace Signed-off-by: Scott Rigby <scott@r6by.com> * Implement semantic line breaks for better diffs. See https://sembr.org/ Signed-off-by: Scott Rigby <scott@r6by.com> * Suggested edits for clarity and flow Signed-off-by: Scott Rigby <scott@r6by.com> * Not only for DevOps professionals Signed-off-by: Scott Rigby <scott@r6by.com> Co-authored-by: lloydchang <lloydchang@gmail.com> * Change tense now that we have a 1.0, which establishes a foundation for… Signed-off-by: Scott Rigby <scott@r6by.com> * Update content/blog/1.0-announcement/index.mdx Co-authored-by: lloydchang <lloydchang@gmail.com> Signed-off-by: Dan Garfield <dan@codefresh.io> * Update content/blog/1.0-announcement/index.mdx Co-authored-by: Scott Rigby <scott@r6by.com> Signed-off-by: Dan Garfield <dan@codefresh.io> Co-authored-by: Roberth Strand <me@robstr.dev> Co-authored-by: Nicholas Thomson <RedbackThomson@users.noreply.github.com> Co-authored-by: Christian Hernandez <christianh814@users.noreply.github.com> Co-authored-by: Stacey Potter <50154848+staceypotter@users.noreply.github.com> Co-authored-by: Dan Garfield <dan@todaywasawesome.com> Co-authored-by: Dan Garfield <dan@codefresh.io> Co-authored-by: lloydchang <lloydchang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Create a Github action using the "peaceiris/actions-gh-pages" action step to deploy to Github pages. Uses the
contents: writepermission to gain write access to branches (through theGITHUB_TOKENsecret).Added a CNAME file for consistency with Github pages documentation.