[#5958] Add support for logic rules in v3 Form serializer

[vaszig]

Closes #5958

Changes

• Add new field logic_rules to the new v3 form endpoint
• Add validation concerning the logic rules and actions
• Add tests

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Checked new model fields are usable in the admin
  • Problem detection in the admin email digest is handled

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

• Documentation

  • Added documentation which describes the changes

[codecov]

Codecov Report

❌ Patch coverage is 97.59036% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.23%. Comparing base (0bbb02f) to head (9a5df6d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/openforms/forms/api/v3/serializers/form.py	95.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #6490    +/-   ##
========================================
  Coverage   97.22%   97.23%            
========================================
  Files         860      861     +1     
  Lines       33061    33223   +162     
  Branches     2999     3019    +20     
========================================
+ Hits        32143    32303   +160     
  Misses        606      606            
- Partials      312      314     +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sergei-maertens]

Quite a number of remarks, but in general I think you managed this well - the current codebase doesn't allow for a much cleaner implementation :-)

[sergei-maertens]

The implementation is quite visibly overloading and long (making it harder to review). I'd consider breaking out the various action-type specific validations into little helper functions and wire them up in this method with some pattern matching:

match action:
    case {"type": LogicActionTypes.variable}:
        ...
    case {"type": str(action_type)} if action_type in LOGIC_ACTION_TYPES_REQUIRING_COMPONENT:
        errors = _check_component_action_definition(...)

together with the collection of all errors, you can cut down on a lot of boilerplate and avoid repeating this block all the time as well:

                            "logic_rules": {
                                str(rule.order): {
                                    "actions": {
                                        str(action_index): {
                                            ...
                                        }
                                    }
                                }
                            }

[sergei-maertens]

there was a crash recently w/r to this kind of validation running for appointment forms or forms that didn't have any steps at all - this should now not happen anymore because we already have the earlier validation about the number of steps per component type, right?

[vaszig]

This is executed only if there are logic rules. If there are and we have no steps then we get an AssertionError from logic analysis (here I should put a default value of None which I forgot).