Implementing formio-builder FormBuilder - #6455
Draft
robinmolen wants to merge 5 commits into
Draft
Conversation
robinmolen
force-pushed
the
feature/offb-271-implementing-OF-form-builder
branch
from
July 15, 2026 08:46
491cde2 to
92d79e8
Compare
| "USE_OF_FORM_DESIGNER": [ | ||
| { | ||
| "condition": "boolean", | ||
| "value": config("USE_OF_FORM_DESIGNER", default=False), |
Member
There was a problem hiding this comment.
Suggested change
| "value": config("USE_OF_FORM_DESIGNER", default=False), | |
| "value": config("USE_OF_FORM_DESIGNER", default=True), |
let's please enable this by default, the feature flag is only there to be able to revert "just in case"
robinmolen
commented
Jul 27, 2026
Comment on lines
+69
to
+79
| const componentsWithSimilarKeys = componentNamespace | ||
| .filter(component => component.key.startsWith(componentKey)) | ||
| .map(component => component.key); | ||
| let index = 0; | ||
| let uniqueKey = componentKey; | ||
|
|
||
| while (componentsWithSimilarKeys.includes(uniqueKey)) { | ||
| index++; | ||
| uniqueKey = `${componentKey}${index}`; | ||
| } | ||
| return uniqueKey; |
Contributor
Author
There was a problem hiding this comment.
form_design/utils.js has a getUniqueKey that does something similar. Lets use that function for this part
robinmolen
force-pushed
the
feature/offb-271-implementing-OF-form-builder
branch
from
August 5, 2026 12:58
92d79e8 to
e499bba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6455 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 861 861
Lines 33168 33168
Branches 3006 3006
=======================================
Hits 32251 32251
Misses 606 606
Partials 311 311 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ed` implementation Made the expected data from the FormBuilder explicit in the onComponentMutated method. This also allows us to supply the onComponentMutated from other sources, without having to mimic the shape of the Formio FormBuilder callbacks.
…ormBuilder component Using the `USE_OF_FORM_DESIGNER` feature flag, the Open Forms admin will either use the Formio or our own formio-builder FormBuilder implementation.
…der Form Designer. The label elements in the backend don't have the same padding as the labels in the formio-builder environment. To compensate for this lack of spacing, the location of the floating action buttons needs to be updated. Additionally, the backend applies padding and margin to ul element, breaking the UI for the components list.
sergei-maertens
force-pushed
the
feature/offb-271-implementing-OF-form-builder
branch
from
August 7, 2026 14:20
e499bba to
3cd19cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/formio-builder#271
Depends on a new formio-builder release, containing the FormBuilder component
Changes
Implements the new
FormBuildercomponent of the formio-builder project, as replacement for the Formio FormBuilder.The formio-builder and Formio FormBuilder's will be used alongside each other. Using the new
USE_OF_FORM_DESIGNERfeature flag the admin can decide to use the formio-builder variant, or to stick to the Formio implementation.To make this duo-support easy-ish to maintain, the shared logic in
form-creation-form.jshas been updated.At some point the Formio implementation, and feature flag, will be completely removed.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Dockerfile/scripts
./binfolderCommit hygiene
Documentation