-
Notifications
You must be signed in to change notification settings - Fork 3
Fix calendar/date picker UX #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 69.06% 69.37% +0.30%
==========================================
Files 290 290
Lines 10769 10738 -31
Branches 1787 1778 -9
==========================================
+ Hits 7438 7449 +11
+ Misses 3327 3285 -42
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
27cbc73 to
240fef1
Compare
|
Had a chat with Laurens - the desired behaviour is to only open the picker on click of the icon rather than on focus of the reference text input. Then we can make the button |
ea8aefc to
77b3dd5
Compare
…get into specific DatePicker widget The interaction code is now reusable and only interacting with the trigger icon should affect the datepicker popout state. However, we do want to position the dialog relative to another element (the text box) and have the option to add additional UI elements to the datepicker for the datetime field.
…n of date picker in calendar
77b3dd5 to
7468073
Compare
The internals have been refactored in the DatePicker components.
Partly closes open-formulieren/open-forms-sdk#863
Discussed with Laurens for the desired interaction: