Skip to content

Conversation

@sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Dec 3, 2025

Partly closes open-formulieren/open-forms-sdk#863

Discussed with Laurens for the desired interaction:

  • don't open the date picker on focus of the reference input (because the keyboard navigation inside the picker is bad at the moment, in the legacy renderer this is skipped over)
  • the calendar icon to toggle the calendar supports click, enter and spacebar to open the calendar and can be reached with keyboard navigation

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 47.27273% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.37%. Comparing base (7f5b549) to head (7cfcc16).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/forms/DatePicker.tsx 37.75% 61 Missing ⚠️
...c/components/forms/DateTimeField/DateTimeField.tsx 28.33% 43 Missing ⚠️
...mponents/forms/DateField/DatePicker/DatePicker.tsx 26.66% 33 Missing ⚠️
src/components/icons/FontAwesome.tsx 87.17% 5 Missing ⚠️
src/components/icons/Icon.tsx 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   69.06%   69.37%   +0.30%     
==========================================
  Files         290      290              
  Lines       10769    10738      -31     
  Branches     1787     1778       -9     
==========================================
+ Hits         7438     7449      +11     
+ Misses       3327     3285      -42     
  Partials        4        4              
Flag Coverage Δ
storybook 89.32% <84.26%> (-0.03%) ⬇️
vitest 54.33% <27.27%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sergei-maertens sergei-maertens force-pushed the issue/sdk-863-fix-date-datetime-picker-ux branch from 27cbc73 to 240fef1 Compare December 3, 2025 13:44
@sergei-maertens sergei-maertens marked this pull request as draft December 3, 2025 13:51
@sergei-maertens
Copy link
Member Author

Had a chat with Laurens - the desired behaviour is to only open the picker on click of the icon rather than on focus of the reference text input. Then we can make the button role="button" again too.

@sergei-maertens sergei-maertens force-pushed the issue/sdk-863-fix-date-datetime-picker-ux branch from ea8aefc to 77b3dd5 Compare December 4, 2025 15:04
…get into specific DatePicker widget

The interaction code is now reusable and only interacting with the
trigger icon should affect the datepicker popout state. However, we do
want to position the dialog relative to another element (the text box)
and have the option to add additional UI elements to the datepicker
for the datetime field.
@sergei-maertens sergei-maertens force-pushed the issue/sdk-863-fix-date-datetime-picker-ux branch from 77b3dd5 to 7468073 Compare December 5, 2025 13:36
The internals have been refactored in the DatePicker components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing features to enable the new renderer

2 participants