-
Notifications
You must be signed in to change notification settings - Fork 7
feat!: add provider event details #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add provider event details #77
Conversation
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
66beea1 to
6a7d7bd
Compare
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
3820c1c to
cb48401
Compare
|
Hey @jescriba, I've marked this as breaking by adding a |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and beneficial breaking change by adding ProviderEventDetails to ProviderEvent, aligning the Swift SDK more closely with the OpenFeature specification. The refactoring to consolidate FlagMetadataValue and EventMetadataValue into a single MetadataValue is an excellent improvement for maintainability and code reuse. The addition of a MockProvider and new tests significantly enhances the test suite's quality. I've provided a few suggestions to further improve the new tests and a minor refactoring suggestion for better code style. Overall, this is a well-executed and valuable contribution.
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good and better aligns with the spec.
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Joshua E. <escribirajoshua@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Joshua E. <escribirajoshua@gmail.com>
Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
4931072 to
0b4dd49
Compare
|
Gemini comments were good so I updated the PR accordingly 👍 |
fabriziodemaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to add the Provider Name to comply to the spec 100%. But this is still a step in the right direction, so I am happy to merge this to begin with
I am probably not the right person to comment on the specifications, but I assumed that the Metadata is not meant to be mapped to a Flag's value: in this sense, the types compatibility is also, perhaps, not mandatory or expected. |
|
Addressed comments 👍 Let me know if there's any remaining changes I should make to land this work |
|
Hey @jescriba, thanks for the contribution. I've merged the PR and the changes will be included in the next release. Would you be interested in joining the org? It doesn't come with any obligations but is the first step in the contributing ladder. It also allows us to include you in reviews and @ mention you in comments. |
🤖 I have created a release *beep* *boop* --- ## [0.5.0](0.4.0...0.5.0) (2025-11-12) ### ⚠ BREAKING CHANGES * add provider event details ([#77](#77)) ### 🐛 Bug Fixes * Prevent race condition on updateContext ([#84](#84)) ([dd23929](dd23929)) ### ✨ New Features * add multiprovider ([#78](#78)) ([869b90a](869b90a)) * add provider event details ([#77](#77)) ([56b477e](56b477e)) * add Tracking API ([#81](#81)) ([c14b0cd](c14b0cd)) * Allow FlagEvaluationDetails to be a public API ([#79](#79)) ([0b07a8f](0b07a8f)) ### 📚 Documentation * Update docs with ImmutableContext ([#72](#72)) ([28ccd3e](28ccd3e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
ProviderEventDetailstoProviderEvent#76ProviderEvent: https://openfeature.dev/specification/types#provider-event-detailsQuestions
configuration_changedevent? Something like:Or could the event metadata support flag values something like:
Breaking Changes
ProviderEventnow contains an associated value forProviderEventDetails. This payload includes the error information now. So consumers of this API - will need to pull the errorCode and message from theProviderEventDetailsstructNew to this repo and spec so open to any feedback 😅