Skip to content

feat: ofrep provider #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rahul-Baradol
Copy link

@Rahul-Baradol Rahul-Baradol commented Jun 24, 2025

This PR

  • adds OFREP provider

Related Issues

Fixes #51

Follow-up Tasks

  • Dev testing
  • Unit tests
  • Docs

Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
@Rahul-Baradol
Copy link
Author

@erenatas
PR is ready for review... please let me know your thoughts!

@erenatas
Copy link
Contributor

You are quick :) I will have a look today

@erenatas
Copy link
Contributor

@beeme1mr Hey, do we have any behavioral tests for OFREP?

@Rahul-Baradol it looks like a nice start, however I don't see any have documentation, code coverage. You can have a look at what we have done over flagd

@Rahul-Baradol
Copy link
Author

Yeah right...took this as a start, and wanted your input before proceeding.
No problem, will write the tests and docs, and we can take from there!

@erenatas
Copy link
Contributor

Yeah right...took this as a start, and wanted your input before proceeding. No problem, will write the tests and docs, and we can take from there!

Its a good start :). The implementation reuses the same reqwest client as well 👍

Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
@Rahul-Baradol
Copy link
Author

@erenatas
have added UTCs and docs...

Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
@Rahul-Baradol Rahul-Baradol requested a review from erka June 29, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create OFREP provider
3 participants