refactor: satisfy requirement 1.3.4 #186
Open
+161
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecolella
approved these changes
Aug 4, 2025
Signed-off-by: Ryan Williams <13791684+RyWilliams@users.noreply.github.com>
RyWilliams
force-pushed
the
feat/requirement-1.3.4
branch
from
46676e1 to
b825518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
InMemoryProviderintoClientto satisfy Requirement 1.3.4Related Issues
Fixes #126
Notes
This seemed like a good issue to attempt to tackle as my first contribution. I'm unsure on if the implementation matches what was expected, so feedback is very welcome here!