Skip to content

Conversation

@avelicka
Copy link
Contributor

This PR

This PR adds Faraday instrumentation configuration.

Example:

OpenFeature::GoFeatureFlag::Options.new(
  endpoint: "http://localhost:1031",
  instrumentation: { name: 'custom_name', instrumenter: MyInstrumenter }
)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @avelicka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to configure Faraday instrumentation within the GoFeatureFlag OpenFeature provider. This enhancement allows developers to easily integrate custom instrumentation middleware into the HTTP client used by the provider, enabling advanced monitoring, logging, or tracing of network requests made to the GoFeatureFlag relay-proxy.

Highlights

  • Faraday Instrumentation Support: The provider now supports configuring Faraday instrumentation, allowing users to integrate custom monitoring or logging for HTTP requests made by the GoFeatureFlag client.
  • New Configuration Option: A new instrumentation option has been added to OpenFeature::GoFeatureFlag::Options, which can be used to pass a hash containing instrumentation details to the Faraday client.
  • Documentation and Testing: The README.md has been updated to reflect the new instrumentation configuration option, and a new unit test ensures the option is correctly handled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@avelicka avelicka force-pushed the feature/faraday_instrumentation branch from 2292c51 to 536325e Compare October 31, 2025 16:48
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Faraday instrumentation, allowing for better monitoring of HTTP requests made by the provider. The changes are well-structured, passing the new instrumentation option from the provider's Options down to the Faraday connection setup. I've added a couple of suggestions to improve the robustness of the new option handling by adding validation and to strengthen the corresponding test case. Overall, this is a great addition.

@avelicka avelicka force-pushed the feature/faraday_instrumentation branch from 536325e to 7adca99 Compare October 31, 2025 16:53
Signed-off-by: avelicka <arunas.velicka@vinted.com>
@avelicka avelicka force-pushed the feature/faraday_instrumentation branch from 7adca99 to 388b267 Compare November 4, 2025 17:01
@beeme1mr beeme1mr changed the title feat: add Faraday instrumentation feat(goff): add Faraday instrumentation Nov 4, 2025
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is a great addition to the provider.

@thomaspoignant thomaspoignant merged commit 6ae223f into open-feature:main Nov 4, 2025
15 checks passed
beeme1mr pushed a commit that referenced this pull request Nov 4, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.1.5](openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5)
(2025-11-04)


### ✨ New Features

* **goff:** add Faraday instrumentation
([#62](#62))
([6ae223f](6ae223f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 21, 2025
## This PR
This PR adds [Faraday
instrumentation](https://github.com/lostisland/faraday/blob/main/docs/middleware/included/instrumentation.md)
configuration.

Example:

```ruby
OpenFeature::GoFeatureFlag::Options.new(
  endpoint: "http://localhost:1031",
  instrumentation: { name: 'custom_name', instrumenter: MyInstrumenter }
)

```

Signed-off-by: avelicka <arunas.velicka@vinted.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 21, 2025
…-feature#63)

🤖 I have created a release *beep* *boop*
---

##
[0.1.5](open-feature/ruby-sdk-contrib@openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5)
(2025-11-04)

### ✨ New Features

* **goff:** add Faraday instrumentation
([open-feature#62](open-feature#62))
([6ae223f](open-feature@6ae223f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 26, 2025
## This PR
This PR adds [Faraday
instrumentation](https://github.com/lostisland/faraday/blob/main/docs/middleware/included/instrumentation.md)
configuration.

Example:

```ruby
OpenFeature::GoFeatureFlag::Options.new(
  endpoint: "http://localhost:1031",
  instrumentation: { name: 'custom_name', instrumenter: MyInstrumenter }
)

```

Signed-off-by: avelicka <arunas.velicka@vinted.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Zaimwa9 pushed a commit to Zaimwa9/ruby-sdk-contrib that referenced this pull request Nov 26, 2025
…-feature#63)

🤖 I have created a release *beep* *boop*
---

##
[0.1.5](open-feature/ruby-sdk-contrib@openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5)
(2025-11-04)

### ✨ New Features

* **goff:** add Faraday instrumentation
([open-feature#62](open-feature#62))
([6ae223f](open-feature@6ae223f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants