-
Notifications
You must be signed in to change notification settings - Fork 10
feat(goff): add Faraday instrumentation #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goff): add Faraday instrumentation #62
Conversation
Summary of ChangesHello @avelicka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to configure Faraday instrumentation within the GoFeatureFlag OpenFeature provider. This enhancement allows developers to easily integrate custom instrumentation middleware into the HTTP client used by the provider, enabling advanced monitoring, logging, or tracing of network requests made to the GoFeatureFlag relay-proxy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
2292c51 to
536325e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Faraday instrumentation, allowing for better monitoring of HTTP requests made by the provider. The changes are well-structured, passing the new instrumentation option from the provider's Options down to the Faraday connection setup. I've added a couple of suggestions to improve the robustness of the new option handling by adding validation and to strengthen the corresponding test case. Overall, this is a great addition.
providers/openfeature-go-feature-flag-provider/lib/openfeature/go-feature-flag/options.rb
Show resolved
Hide resolved
providers/openfeature-go-feature-flag-provider/spec/openfeature/gofeatureflag/options_spec.rb
Show resolved
Hide resolved
536325e to
7adca99
Compare
Signed-off-by: avelicka <arunas.velicka@vinted.com>
7adca99 to
388b267
Compare
thomaspoignant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, this is a great addition to the provider.
🤖 I have created a release *beep* *boop* --- ## [0.1.5](openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5) (2025-11-04) ### ✨ New Features * **goff:** add Faraday instrumentation ([#62](#62)) ([6ae223f](6ae223f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
## This PR This PR adds [Faraday instrumentation](https://github.com/lostisland/faraday/blob/main/docs/middleware/included/instrumentation.md) configuration. Example: ```ruby OpenFeature::GoFeatureFlag::Options.new( endpoint: "http://localhost:1031", instrumentation: { name: 'custom_name', instrumenter: MyInstrumenter } ) ``` Signed-off-by: avelicka <arunas.velicka@vinted.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
…-feature#63) 🤖 I have created a release *beep* *boop* --- ## [0.1.5](open-feature/ruby-sdk-contrib@openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5) (2025-11-04) ### ✨ New Features * **goff:** add Faraday instrumentation ([open-feature#62](open-feature#62)) ([6ae223f](open-feature@6ae223f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
## This PR This PR adds [Faraday instrumentation](https://github.com/lostisland/faraday/blob/main/docs/middleware/included/instrumentation.md) configuration. Example: ```ruby OpenFeature::GoFeatureFlag::Options.new( endpoint: "http://localhost:1031", instrumentation: { name: 'custom_name', instrumenter: MyInstrumenter } ) ``` Signed-off-by: avelicka <arunas.velicka@vinted.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
…-feature#63) 🤖 I have created a release *beep* *boop* --- ## [0.1.5](open-feature/ruby-sdk-contrib@openfeature-go-feature-flag-provider/v0.1.4...openfeature-go-feature-flag-provider/v0.1.5) (2025-11-04) ### ✨ New Features * **goff:** add Faraday instrumentation ([open-feature#62](open-feature#62)) ([6ae223f](open-feature@6ae223f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
This PR
This PR adds Faraday instrumentation configuration.
Example: