-
Notifications
You must be signed in to change notification settings - Fork 24
fix: Hook methods should have default non-abstract implementations #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hook methods should have default non-abstract implementations #216
Conversation
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
a2819cf
to
322a9dc
Compare
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 93.34% 93.27% -0.08%
==========================================
Files 16 16
Lines 451 446 -5
==========================================
- Hits 421 416 -5
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the return value
@beeme1mr the |
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
8621844
to
91f9858
Compare
This PR
Fixes Hook methods incorrectly marked as abstract. The Hook class provides default implementations of all hook lifecycle methods. Hook subclasses only need to override the methods they are interested in.