fix: Add --port argument in flagd pods for set flagd service port #710
+22
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimsehwan96
force-pushed
the
add-port-argument-in-flagd-pods
branch
from
3376172
to
07146d9
Compare
kimsehwan96
changed the title
Signed-off-by: kimsehwan96 <sktpghks138@gmail.com> Add missed mock Ports in flagdinjector_test.go getExpectedPod Signed-off-by: kimsehwan96 <sktpghks138@gmail.com> Change wrong container port name port into flagd
kimsehwan96
force-pushed
the
add-port-argument-in-flagd-pods
branch
from
07146d9
to
c47d623
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 86.51% 87.10% +0.58%
==========================================
Files 19 19
Lines 1587 1326 -261
==========================================
- Hits 1373 1155 -218
+ Misses 173 128 -45
- Partials 41 43 +2
... and 17 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
beeme1mr
approved these changes
Oct 9, 2024
|
@beeme1mr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
--portwith FeatureFlagSoruce configuration)Related Issues
Fixes #709
Notes
Follow-up Tasks
I don't have the background knowledge of why this feature wasn't implemented, and I haven't tested this code, so a thorough PR review is needed
How to test
Set
FeatureFlagSource.spec.portwith specific number and check the--portargument was properly set and check its debug log atinfo flag-evaluation/connect_service.go:227 Flag IResolver listening at: {PORT_NUMBER}