Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix typo flagsValidatonEnabled into flagsValidationEnabled #707

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

kimsehwan96
Copy link
Contributor

This PR

  • Fix typo in helm value and template flagsValidatonEnabled into flagsValidationEnabled

Related Issues

None

Notes

Follow-up Tasks

How to test

@kimsehwan96 kimsehwan96 requested a review from a team as a code owner October 2, 2024 07:29
Signed-off-by: kimsehwan96 <sktpghks138@gmail.com>
@kimsehwan96 kimsehwan96 changed the title Fix typo flagsValidatonEnabled into flagsValidationEnabled fix: Fix typo flagsValidatonEnabled into flagsValidationEnabled Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (499661e) to head (137681e).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   86.51%   87.05%   +0.53%     
==========================================
  Files          19       19              
  Lines        1587     1321     -266     
==========================================
- Hits         1373     1150     -223     
+ Misses        173      128      -45     
- Partials       41       43       +2     

see 18 files with indirect coverage changes

Flag Coverage Δ
unit-tests 87.05% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@beeme1mr
Copy link
Member

beeme1mr commented Oct 2, 2024

Thanks @kimsehwan96! Could you please use ./.github/scripts/generate-helm-docs.sh to re-generate the Helm docs?

@toddbaert
Copy link
Member

Thanks @kimsehwan96! Could you please use ./.github/scripts/generate-helm-docs.sh to re-generate the Helm docs?

There's a little more required than that, but I've pushed an update.

Thanks @kimsehwan96

@toddbaert toddbaert changed the title fix: Fix typo flagsValidatonEnabled into flagsValidationEnabled fix!: Fix typo flagsValidatonEnabled into flagsValidationEnabled Oct 2, 2024
@toddbaert toddbaert merged commit 64cdc25 into open-feature:main Oct 2, 2024
17 of 19 checks passed
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants