feat: Decouple feature flag spec from flagd config #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan
requested review from
AlexsJones,
beeme1mr and
skyerus
as code owners
|
Ill expand the test suite once everyone is happy with the approach |
skyerus
reviewed
Dec 13, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan
commented
Dec 13, 2022
skyerus
reviewed
Dec 13, 2022
beeme1mr
reviewed
Dec 13, 2022
caught using |
toddbaert
reviewed
Dec 13, 2022
toddbaert
reviewed
Dec 13, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 50.90% 50.82% -0.08%
==========================================
Files 3 4 +1
Lines 444 486 +42
==========================================
+ Hits 226 247 +21
- Misses 202 221 +19
- Partials 16 18 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
skyerus
reviewed
Dec 14, 2022
skyerus
reviewed
Dec 14, 2022
skyerus
reviewed
Dec 14, 2022
|
Converting to draft until I return from my Christmas break! 🎅 |
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
skyerus
approved these changes
Jan 4, 2023
6 tasks
beeme1mr
reviewed
Jan 5, 2023
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
|
Hey @toddbaert @AlexsJones, any concerns about this PR? It would be great to get this merged so @james-milligan can add support for these settings in Helm. |
toddbaert
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Hey @toddbaert @AlexsJones, any concerns about this PR? It would be great to get this merged so @james-milligan can #271.
@beeme1mr My only concern was this which is resolved now. Approved.
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
flagDConfigfield of theFeatureflagConfigurationcrdFlagSourceConfigurationto handle the configopenfeature.dev/flagsourceconfigurationand associated documentationRelated Issues
#274
Notes
Follow-up Tasks
How to test