-
Notifications
You must be signed in to change notification settings - Fork 1
feat!: Bootstrap project and implement env-var provider #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only made it part way through the review but I wanted to leave some initial thoughts.
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started, @bencehornak! Let's see what @toddbaert says about the Release Please config.
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bencehornak, could you please remove the Release Please config from this PR and open a separate issue? It will take a bit to get that setup and I don't want to hold up this PR.
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
The |
I believe this is a security mechanism in GitHub to prevent people from leaking secrets. It should run for future PRs once this has been merged. I'm going to get this in now. Thanks @bencehornak for your hard work. |
This PR
Depends on open-feature/kotlin-sdk#148
Notes
There is ongoing work to make the Kotlin SDK multiplatform-based, see open-feature/kotlin-sdk#148. I suggest this and the other PR to be reviewed together and to build this repo against locally published artifacts of the Kotlin SDK based on the other PR.
Feel free to push to the branch, lmk if you need access to it.
To do
Set up Release-Please-> will be done in Configure Release-please #2Set up FOSS score?-> would do later to keep this PR small... let me know, if further points are missing, I can add them to the list.
How to test
As far as the env-var provider is concerned I'm planning to create a KMP example app as part of open-feature/kotlin-sdk#148, we can make use of that to test it.
There are many other things to test, mainly the CI and the publishing, we will surely notice problems with those.