-
Notifications
You must be signed in to change notification settings - Fork 40
feat(web-global-build): impl #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @zdunecki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've introduced a new global IIFE build for the web SDK. This change enables the OpenFeature SDK to be distributed via CDNs like unpkg and jsdelivr, allowing it to be loaded as a first dependency before the browser resolves other modules. This is a significant step towards broader accessibility and easier integration for web projects.
Highlights
- Global Build Implementation: I've implemented a new global (IIFE) build for the web SDK, outputting to dist/global/index.js and exposing OpenFeature globally.
- CDN Support: I've added unpkg and jsdelivr fields to package.json to facilitate global distribution via CDNs.
- Build Process Update: I've updated the main build script to include the new global build process, ensuring it's part of the standard build flow.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a global IIFE build for the web package, enabling its distribution via CDNs like unpkg and jsdelivr. The changes in package.json
add the necessary CDN entry points and a new build:web-global
npm script. The implementation is solid, but I've suggested one improvement: adding sourcemap generation to the new build script to improve debuggability for consumers of the CDN build.
This PR
unpkg
andjsdelivr
fields inpackage.json
.Notes
dist/global/index.js
.OpenFeature
.Follow-up Tasks
How to test
npm run build
and ensuredist/global/index.js
is generated.window.OpenFeature
is available in the browser console.Motivation
Trying to load OpenFeature as a first dependency before browser will resolve any modules.