feat!: improve eval performance, restructure lib, support flag metadata #1120

beeme1mr · 2024-12-20T21:45:34Z

This PR

improve evaluation performance by preloading the config into JSON Logic Engine
bumped json logic engine version
return evaluation details instead of throwing
converted all logs to debug
add flag metadata

Related Issues

Pre-req for #1115

Notes

It should be released as v1.

Follow-up Tasks

Use in the flagd playground app
Using the the flagd JS providers

How to test

There are Jest unit tests

libs/shared/flagd-core/src/lib/feature-flag.ts

libs/shared/flagd-core/src/lib/flagd-core.spec.ts

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

libs/shared/flagd-core/src/lib/feature-flag.ts

libs/shared/flagd-core/src/lib/flagd-core.ts

libs/shared/flagd-core/src/lib/storage.ts

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

release-please-config.json

libs/shared/flagd-core/package.json

libs/shared/flagd-core/src/lib/feature-flag.ts

libs/shared/flagd-core/src/lib/flagd-core.spec.ts

libs/shared/flagd-core/src/lib/flagd-core.ts

libs/shared/flagd-core/src/lib/parser.ts

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

beeme1mr changed the title ~~feat!: improve eval performance, restructure lib~~ feat!: improve eval performance, restructure lib, support flag metadata Dec 24, 2024

beeme1mr commented Dec 24, 2024

View reviewed changes

libs/shared/flagd-core/src/lib/feature-flag.ts Show resolved Hide resolved

beeme1mr commented Jan 3, 2025

View reviewed changes

libs/shared/flagd-core/src/lib/feature-flag.ts Outdated Show resolved Hide resolved

libs/shared/flagd-core/src/lib/flagd-core.spec.ts Outdated Show resolved Hide resolved

beeme1mr force-pushed the improve-flagd-core branch from e12b784 to 630fc1a Compare January 6, 2025 16:22

github-actions bot assigned beeme1mr and toddbaert Jan 6, 2025

github-actions bot requested a review from toddbaert January 6, 2025 16:23

beeme1mr force-pushed the improve-flagd-core branch from 630fc1a to add328b Compare January 6, 2025 16:26

feat: improve eval performance, restructure lib, support flag metadata

6cd5578

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

beeme1mr force-pushed the improve-flagd-core branch from add328b to 6cd5578 Compare January 6, 2025 16:30

beeme1mr commented Jan 6, 2025

View reviewed changes

libs/shared/flagd-core/src/lib/feature-flag.ts Outdated Show resolved Hide resolved

beeme1mr commented Jan 6, 2025

View reviewed changes

beeme1mr added 6 commits January 6, 2025 19:27

action pr feedback

d74e72d

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

fix package lock

45ab996

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

fix lint issues

8e3b8f8

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

renamed vars for consistancy

103fb3c

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

regenerate package lock

c147dfc

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

only update the json-logic-engine version in the package lock

5fbc688

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>

beeme1mr commented Jan 6, 2025

View reviewed changes

release-please-config.json Show resolved Hide resolved

beeme1mr marked this pull request as ready for review January 6, 2025 20:44

beeme1mr requested a review from a team as a code owner January 6, 2025 20:44

toddbaert mentioned this pull request Jan 6, 2025

feat: Update in-process resolver to support flag metadata #1102 open-feature/java-sdk-contrib#1122

Merged