-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(flipt): upgrade Flipt provider to use latest 1.0.0 Flipt SDK #638
Conversation
1d0abcd
to
516a3fc
Compare
@liran2000 could you help me debug why CI is failing please? It seems to be potentially getting a 500 from wiremock?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure.
Added review comments. Could not add changes to the PR, I tested the changes and it passes the tests locally at the IDE.
providers/flipt/src/test/java/dev/openfeature/contrib/providers/flipt/FliptProviderTest.java
Show resolved
Hide resolved
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
01d9f72
to
45d2faf
Compare
I'm seeing:
I'll try to look into this on monday... looks like it might be warnings coming from a dependency 🤔 |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
3c8f8ec
to
f6c10c9
Compare
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
…java-sdk-contrib into upgrade-flipt-provider * 'upgrade-flipt-provider' of https://github.com/flipt-io/java-sdk-contrib: chore(flipt): bump flipt dep refactor(flipt): upgrade Flipt provider to use latest 1.0.0 Flipt SDK
Thanks all!! Much appreciated! |
…ure#638) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR
Related Issues
Closes: #636
Notes
Follow-up Tasks
How to test