Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing image delimiter #463

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

Kavindu-Dodan
Copy link
Contributor

This PR

Fixes image version delimiter to match digest usage [1]

:tag vs @digest

[1]. - https://docs.docker.com/engine/reference/run/#general-form

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
# Conflicts:
#	.github/workflows/release-please.yaml
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@toddbaert toddbaert merged commit b4ee495 into open-feature:main Mar 3, 2023
@beeme1mr beeme1mr self-requested a review March 3, 2023 14:43
@Kavindu-Dodan Kavindu-Dodan changed the title fix: fixing image delimeter fix: fixing image delimiter Mar 3, 2023
beeme1mr pushed a commit that referenced this pull request Mar 7, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](v0.4.0...v0.4.1)
(2023-03-07)


### 🔄 Refactoring

* remove unused struct field
([#458](#458))
([a04c0b8](a04c0b8))


### 🧹 Chore

* **deps:** update sigstore/cosign-installer digest to bd2d118
([#471](#471))
([ee90f48](ee90f48))


### 🐛 Bug Fixes

* **deps:** update module
github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.10
([#459](#459))
([cbdf9b0](cbdf9b0))
* **deps:** update module golang.org/x/net to v0.8.0
([#468](#468))
([10d5f2c](10d5f2c))
* fix broken image signing
([#461](#461))
([05bb51c](05bb51c))
* fixing image delimeter
([#463](#463))
([b4ee495](b4ee495))
* security issues
([#464](#464))
([7f1e759](7f1e759))
* set readiness once only
([#465](#465))
([41a888d](41a888d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Kavindu-Dodan Kavindu-Dodan deleted the fix/image-digest branch March 9, 2023 22:13
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants