fix(security): update module github.com/go-viper/mapstructure/v2 to v2.3.0 [security] #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![renovate-approve-2[bot]](https://avatars.githubusercontent.com/in/62175?s=60&v=4){kind=small}
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Jul 14, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.12.6</summary> ## [0.12.6](flagd/v0.12.5...flagd/v0.12.6) (2025-07-10) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.3.0 [security] ([#1667](#1667)) ([caa0ed0](caa0ed0)) ### ✨ New Features * add sync_context to SyncFlags ([#1642](#1642)) ([07a45d9](07a45d9)) </details> <details><summary>flagd-proxy: 0.7.5</summary> ## [0.7.5](flagd-proxy/v0.7.4...flagd-proxy/v0.7.5) (2025-07-10) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.3.0 [security] ([#1667](#1667)) ([caa0ed0](caa0ed0)) ### ✨ New Features * add sync_context to SyncFlags ([#1642](#1642)) ([07a45d9](07a45d9)) </details> <details><summary>core: 0.11.6</summary> ## [0.11.6](core/v0.11.5...core/v0.11.6) (2025-07-10) ### ✨ New Features * add sync_context to SyncFlags ([#1642](#1642)) ([07a45d9](07a45d9)) * allowing null/missing defaultValue ([#1659](#1659)) ([3f6b78c](3f6b78c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.2.1->v2.3.0GitHub Vulnerability Alerts
GHSA-fv92-fjc5-jj9h
Summary
Use of this library in a security-critical context may result in leaking sensitive information, if used to process sensitive fields.
Details
OpenBao (and presumably HashiCorp Vault) have surfaced error messages from
mapstructureas follows:https://github.com/openbao/openbao/blob/98c3a59c040efca724353ca46ca79bd5cdbab920/sdk/framework/field_data.go#L43-L50
where this calls
mapstructure.WeakDecode(...): https://github.com/openbao/openbao/blob/98c3a59c040efca724353ca46ca79bd5cdbab920/sdk/framework/field_data.go#L181-L193Notably,
WeakDecode(...)eventually calls one of the decode helpers, which surfaces the original value:https://github.com/go-viper/mapstructure/blob/1a66224d5e54d8757f63bd66339cf764c3292c21/mapstructure.go#L679-L686
https://github.com/go-viper/mapstructure/blob/1a66224d5e54d8757f63bd66339cf764c3292c21/mapstructure.go#L726-L730
https://github.com/go-viper/mapstructure/blob/1a66224d5e54d8757f63bd66339cf764c3292c21/mapstructure.go#L783-L787
& more.
PoC
To reproduce with OpenBao:
and in a new tab:
Impact
This is an information disclosure bug with little mitigation. See https://discuss.hashicorp.com/t/hcsec-2025-09-vault-may-expose-sensitive-information-in-error-logs-when-processing-malformed-data-with-the-kv-v2-plugin/74717 for a previous version. That version was fixed, but this is in the second part of that error message (starting at
'' expected a map, got 'string'-- when the field type isstringand amapis provided, we see the above information leak -- the previous example had amaptype field with astringvalue provided).This was rated 4.5 Medium by HashiCorp in the past iteration.
Release Notes
go-viper/mapstructure (github.com/go-viper/mapstructure/v2)
v2.3.0Compare Source
What's Changed
reflect.ValueinComposeDecodeHookFuncby @mahadzaryab1 in https://github.com/go-viper/mapstructure/pull/52New Contributors
Full Changelog: go-viper/mapstructure@v2.2.1...v2.3.0
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.