Skip to content

Conversation

@beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Feb 18, 2025

This PR

  • adds providerId as a valid configuration option

Related Issues

Relates to open-feature/go-sdk-contrib#626

Notes

provider_id is supported in sync request proto. This change specifics how the properties could be set in the provider.

Follow-up Tasks

Update test bed config.feature.

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team February 18, 2025 19:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2025
@beeme1mr beeme1mr requested review from aepfli and chrfwow February 18, 2025 19:02
@netlify
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 03d2ebb
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/67e3d5e348520f0008f39ced

@beeme1mr beeme1mr requested a review from toddbaert February 18, 2025 19:02
@beeme1mr beeme1mr requested a review from cupofcat March 10, 2025 17:37
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr changed the title docs: add providerID as a configuration option docs: add providerId as a configuration option Mar 11, 2025
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli added a commit to open-feature/flagd-testbed that referenced this pull request Mar 26, 2025
relates: open-feature/flagd#1567
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@beeme1mr beeme1mr merged commit ddfa020 into main Mar 27, 2025
10 checks passed
@beeme1mr beeme1mr deleted the add-provider-id branch March 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants