feat: improve error log and add flag disabled handling for ofrep #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
toddbaert
approved these changes
May 9, 2024
…ing rule Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
feat/improve-ofrep-error-handling
branch
from
17da47d to
48c7217
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
+ Coverage 73.69% 77.31% +3.61%
==========================================
Files 32 20 -12
Lines 3140 1622 -1518
==========================================
- Hits 2314 1254 -1060
+ Misses 717 286 -431
+ Partials 109 82 -27 ☔ View full report in Codecov by Sentry. |
beeme1mr
approved these changes
May 9, 2024
beeme1mr
requested changes
May 9, 2024
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
beeme1mr
approved these changes
May 9, 2024
Merged
Kavindu-Dodan
pushed a commit
that referenced
this pull request
May 10, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.2</summary> ## [0.10.2](flagd/v0.10.1...flagd/v0.10.2) (2024-05-10) ### ✨ New Features * Create interface for eval events. ([#1288](#1288)) ([9714215](9714215)) ### 🧹 Chore * bump go deps to latest ([#1307](#1307)) ([004ad08](004ad08)) </details> <details><summary>flagd-proxy: 0.6.2</summary> ## [0.6.2](flagd-proxy/v0.6.1...flagd-proxy/v0.6.2) (2024-05-10) ### 🧹 Chore * bump go deps to latest ([#1307](#1307)) ([004ad08](004ad08)) </details> <details><summary>core: 0.9.2</summary> ## [0.9.2](core/v0.9.1...core/v0.9.2) (2024-05-10) ### ✨ New Features * improve error log and add flag disabled handling for ofrep ([#1306](#1306)) ([39ae4fe](39ae4fe)) ### 🧹 Chore * bump go deps to latest ([#1307](#1307)) ([004ad08](004ad08)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
FlagDisabledErrorCodeand include a specific error message along with general error code