Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: SourceLink is built-in for .NET SDK 8.0.100+ #198

Merged
merged 1 commit into from
Jan 23, 2024
Merged

chore: SourceLink is built-in for .NET SDK 8.0.100+ #198

merged 1 commit into from
Jan 23, 2024

Conversation

austindrenski
Copy link
Member

@austindrenski austindrenski commented Jan 22, 2024 •
edited
Loading

Using Source Link in .NET projects

Starting with .NET 8, Source Link for the following source control providers is included in the .NET SDK and enabled by default:

If your project uses .NET SDK 8+ and is hosted by the above providers it does not need to reference any Source Link packages or set any build properties.

Otherwise, you can enable Source Link experience in your project by setting a few properties and adding a PackageReference to a Source Link package specific to the provider:

<Project>
 <PropertyGroup>
    <!-- Optional: Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
    <PublishRepositoryUrl>true</PublishRepositoryUrl>
 
    <!-- Optional: Embed source files that are not tracked by the source control manager in the PDB -->
    <EmbedUntrackedSources>true</EmbedUntrackedSources>
  </PropertyGroup>
  <ItemGroup>
    <!-- Add PackageReference specific for your source control provider (see below) --> 
  </ItemGroup>
</Project>

See: open-feature/dotnet-sdk-contrib#143

@austindrenski austindrenski self-assigned this Jan 22, 2024
@austindrenski austindrenski requested a review from a team as a code owner January 22, 2024 18:25
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0fbbcd) 93.50% compared to head (2a237c7) 93.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          23       23           
  Lines         954      954           
  Branches      105      105           
=======================================
  Hits          892      892           
  Misses         38       38           
  Partials       24       24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@austindrenski austindrenski mentioned this pull request Jan 22, 2024
Merged
@austindrenski
chore: SourceLink is built-in for .NET SDK 8.0.100+
2a237c7 
Signed-off-by: Austin Drenski <austin@austindrenski.io>
@austindrenski austindrenski merged commit 45e2c86 into open-feature:main Jan 23, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
@austindrenski austindrenski deleted the source-link-built-in branch January 24, 2024 13:22
askpt pushed a commit that referenced this pull request Jan 30, 2024
@austindrenski @askpt
chore: SourceLink is built-in for .NET SDK 8.0.100+ (#198)
454a277 
Signed-off-by: Austin Drenski <austin@austindrenski.io>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr pushed a commit that referenced this pull request Mar 12, 2024
@github-actions
chore(main): release 1.5.0 (#205)
b23334b 
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](v1.4.1...v1.5.0)
(2024-03-12)


### 🐛 Bug Fixes

* Add targeting key
([#231](#231))
([d792b32](d792b32))
* Fix NU1009 reference assembly warning
([#222](#222))
([7eebcdd](7eebcdd))
* invalid editorconfig
([#244](#244))
([3c00757](3c00757))


### ✨ New Features

* Flag metadata
([#223](#223))
([fd0a541](fd0a541))
* implement in-memory provider
([#232](#232))
([1082094](1082094))


### 🧹 Chore

* bump spec version badge
([#246](#246))
([ebf5552](ebf5552))
* cleanup unused usings 🧹
([#240](#240))
([cdc1bee](cdc1bee))
* **deps:** update actions/upload-artifact action to v4.3.0
([#203](#203))
([0a7e98d](0a7e98d))
* **deps:** update actions/upload-artifact action to v4.3.1
([#233](#233))
([cfaf1c8](cfaf1c8))
* **deps:** update codecov/codecov-action action to v3.1.5
([#209](#209))
([a509b1f](a509b1f))
* **deps:** update codecov/codecov-action action to v3.1.6
([#226](#226))
([a577a80](a577a80))
* **deps:** update dependency coverlet.collector to v6.0.1
([#238](#238))
([f2cb67b](f2cb67b))
* **deps:** update dependency fluentassertions to v6.12.0
([#215](#215))
([2c237df](2c237df))
* **deps:** update dependency microsoft.net.test.sdk to v17.8.0
([#216](#216))
([4cb3ae0](4cb3ae0))
* **deps:** update dependency nsubstitute to v5.1.0
([#217](#217))
([3be76cd](3be76cd))
* **deps:** update dependency openfeature.contrib.providers.flagd to
v0.1.8 ([#211](#211))
([c1aece3](c1aece3))
* **deps:** update xunit-dotnet monorepo
([#236](#236))
([fa25ece](fa25ece))
* Enable Central Package Management (CPM)
([#178](#178))
([249a0a8](249a0a8))
* Enforce coding styles on build
([#242](#242))
([64699c8](64699c8))
* More sln cleanup
([#206](#206))
([bac3d94](bac3d94))
* SourceLink is built-in for .NET SDK 8.0.100+
([#198](#198))
([45e2c86](45e2c86))
* Sync ci.yml with contrib repo
([#196](#196))
([130654b](130654b))
* Sync release.yml with ci.yml following
[#173](#173)
([#195](#195))
([eba8848](eba8848))


### 📚 Documentation

* fix hook ecosystem link
([#229](#229))
([cc6c404](cc6c404))
* update the feature table key
([f8724cd](f8724cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
@austindrenski @arttonoyan
chore: SourceLink is built-in for .NET SDK 8.0.100+ (open-feature#198)
2335060 
Signed-off-by: Austin Drenski <austin@austindrenski.io>
Signed-off-by: Artyom Tonoyan <artonoyan@servicetitan.com>
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
@github-actions @arttonoyan
chore(main): release 1.5.0 (open-feature#205)
454d20e 
🤖 I have created a release *beep* *boop*
---

##
[1.5.0](open-feature/dotnet-sdk@v1.4.1...v1.5.0)
(2024-03-12)

### 🐛 Bug Fixes

* Add targeting key
([open-feature#231](open-feature#231))
([d792b32](open-feature@d792b32))
* Fix NU1009 reference assembly warning
([open-feature#222](open-feature#222))
([7eebcdd](open-feature@7eebcdd))
* invalid editorconfig
([open-feature#244](open-feature#244))
([3c00757](open-feature@3c00757))

### ✨ New Features

* Flag metadata
([open-feature#223](open-feature#223))
([fd0a541](open-feature@fd0a541))
* implement in-memory provider
([open-feature#232](open-feature#232))
([1082094](open-feature@1082094))

### 🧹 Chore

* bump spec version badge
([open-feature#246](open-feature#246))
([ebf5552](open-feature@ebf5552))
* cleanup unused usings 🧹
([open-feature#240](open-feature#240))
([cdc1bee](open-feature@cdc1bee))
* **deps:** update actions/upload-artifact action to v4.3.0
([open-feature#203](open-feature#203))
([0a7e98d](open-feature@0a7e98d))
* **deps:** update actions/upload-artifact action to v4.3.1
([open-feature#233](open-feature#233))
([cfaf1c8](open-feature@cfaf1c8))
* **deps:** update codecov/codecov-action action to v3.1.5
([open-feature#209](open-feature#209))
([a509b1f](open-feature@a509b1f))
* **deps:** update codecov/codecov-action action to v3.1.6
([open-feature#226](open-feature#226))
([a577a80](open-feature@a577a80))
* **deps:** update dependency coverlet.collector to v6.0.1
([open-feature#238](open-feature#238))
([f2cb67b](open-feature@f2cb67b))
* **deps:** update dependency fluentassertions to v6.12.0
([open-feature#215](open-feature#215))
([2c237df](open-feature@2c237df))
* **deps:** update dependency microsoft.net.test.sdk to v17.8.0
([open-feature#216](open-feature#216))
([4cb3ae0](open-feature@4cb3ae0))
* **deps:** update dependency nsubstitute to v5.1.0
([open-feature#217](open-feature#217))
([3be76cd](open-feature@3be76cd))
* **deps:** update dependency openfeature.contrib.providers.flagd to
v0.1.8 ([open-feature#211](open-feature#211))
([c1aece3](open-feature@c1aece3))
* **deps:** update xunit-dotnet monorepo
([open-feature#236](open-feature#236))
([fa25ece](open-feature@fa25ece))
* Enable Central Package Management (CPM)
([open-feature#178](open-feature#178))
([249a0a8](open-feature@249a0a8))
* Enforce coding styles on build
([open-feature#242](open-feature#242))
([64699c8](open-feature@64699c8))
* More sln cleanup
([open-feature#206](open-feature#206))
([bac3d94](open-feature@bac3d94))
* SourceLink is built-in for .NET SDK 8.0.100+
([open-feature#198](open-feature#198))
([45e2c86](open-feature@45e2c86))
* Sync ci.yml with contrib repo
([open-feature#196](open-feature#196))
([130654b](open-feature@130654b))
* Sync release.yml with ci.yml following
[open-feature#173](open-feature#173)
([open-feature#195](open-feature#195))
([eba8848](open-feature@eba8848))

### 📚 Documentation

* fix hook ecosystem link
([open-feature#229](open-feature#229))
([cc6c404](open-feature@cc6c404))
* update the feature table key
([f8724cd](open-feature@f8724cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Artyom Tonoyan <artonoyan@servicetitan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjiro benjiro benjiro approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@austindrenski austindrenski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austindrenski @beeme1mr @benjiro