Skip to content

Conversation

@cjsha
Copy link
Member

@cjsha cjsha commented Jul 16, 2025

fix #29

@cjsha cjsha requested a review from ChucklesOnGitHub July 16, 2025 21:12
Copy link
Member

@ChucklesOnGitHub ChucklesOnGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder - and I realize this is a pain to change - if it would be better to refer to the "center/side top/bottom" SMA connectors as "top/bottom center/side", because one first looks at the top or bottom of the commutator, then at the center or side connector, as opposed to the opposite.

@cjsha
Copy link
Member Author

cjsha commented Jul 18, 2025

I think you're right. However, my concern is, for example, that "bottom side" can be interpreted as the side that is bottom. do you get what I mean? like, both bottom connectors are on the "bottom side"

What do you think of "Top outer" and "Bottom outer" instead of "Top side" and "Bottom side". Can you think of other options? am I overthinking this?

@ChucklesOnGitHub
Copy link
Member

I think you're right. However, my concern is, for example, that "bottom side" can be interpreted as the side that is bottom. do you get what I mean? like, both bottom connectors are on the "bottom side"

What do you think of "Top outer" and "Bottom outer" instead of "Top side" and "Bottom side". Can you think of other options? am I overthinking this?

I see. Yeah, outer / inner would work, or center / off-center. The rotary joint has them labelled as 1 and 2 which was my first thought on how to solve this but I actually think that it is unhelpful because it is hardly visible and not intuitive which would be which without looking.

@cjsha cjsha requested a review from ChucklesOnGitHub August 20, 2025 19:14
@ChucklesOnGitHub ChucklesOnGitHub merged commit 9ff7307 into main Aug 29, 2025
2 checks passed
@ChucklesOnGitHub ChucklesOnGitHub deleted the issue-29 branch August 29, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dual-coax commutator to docs

3 participants