Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly link Trigger operators to their constituent Configure operator #292

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

bparks13
Copy link
Member

@bparks13 bparks13 commented Sep 6, 2024

Currently there is no indication of how to link a Trigger operator to the Configure operator. By adding remarks in this PR, this linking is now explicitly stated.

Fixes #211

- Currently there is no indication of how to link a Trigger operator to the Configure operator. By adding remarks, this linking is now explicitly stated
@bparks13 bparks13 added this to the 0.3.0 milestone Sep 6, 2024
@bparks13 bparks13 requested a review from cjsha September 6, 2024 15:20
@bparks13 bparks13 self-assigned this Sep 6, 2024
Copy link
Member

@cjsha cjsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect the docs immediately because some changes need be made to the template in order to pull in these remarks in and use them effectively. However, I examined the raw data model generated by docfx, and the remarks content generated by the tag looks exactly like what the OpticalStimulator and ElectricalStimulator sections in the ConfigureHeadstage64 page need.

@cjsha cjsha merged commit e4a0b3f into main Sep 6, 2024
7 checks passed
@bparks13 bparks13 deleted the issue-211 branch September 19, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headstage64 ElectricalStimulator & OpticalStimulator Remarks require more information
2 participants